Skip to content

Skip autostart for conditionally skipped lifecycle components - #555

Open
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/skip-autostart-for-filtered-lifecycle-components
Open

Skip autostart for conditionally skipped lifecycle components#555
Old-Ding wants to merge 1 commit into
ros2:rollingfrom
Old-Ding:codex/skip-autostart-for-filtered-lifecycle-components

Conversation

@Old-Ding

Copy link
Copy Markdown

Summary

  • keep lifecycle autostart handling scoped to composable nodes that produced a load request
  • avoid dereferencing an absent request when a composable lifecycle node condition is false
  • cover condition=False together with autostart=True

Testing

  • focused source behavior probe: baseline raises AttributeError and the fixed code completes without scheduling the filtered node
  • python -m py_compile for both modified Python files
  • flake8 on both modified files with the repository's existing E501/W504 exclusions
  • git diff --check

A composable lifecycle node with a false condition does not produce a load request. Avoid creating its autostart transition from that absent request, and cover the conditional autostart case.

Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant