Fix launch_testing_ros compatibility with legacy hook specs - #551
Open
Old-Ding wants to merge 2 commits into
Open
Fix launch_testing_ros compatibility with legacy hook specs#551Old-Ding wants to merge 2 commits into
Old-Ding wants to merge 2 commits into
Conversation
Use the path argument retained by the current launch_testing hookspec so the launch_ros plugin also registers with older path-only versions. Cover both hookspec shapes with focused plugin registration tests. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Order the new test imports according to the ament flake8 policy so the repository lint job accepts the compatibility coverage. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
launch_testingnow keeps bothmodule_pathandpathin its current hook specification, while older released versions only exposepath.launch_ros0.29.9 declares onlymodule_path, so Pluggy rejects the plugin when those package versions are mixed.Use the
pathargument shared by both released hook specifications and add focused registration tests for the legacy and current shapes.Addresses #550. This should be backported to Lyrical after merging in Rolling.
Is this user-facing behavior change?
Yes. Launch tests can be collected when a newer
launch_testing_rosis used with an older path-onlylaunch_testingrelease, instead of failing during pytest plugin registration.Did you use Generative AI?
Yes. OpenAI Codex (GPT-5) assisted with root-cause analysis and preparing the focused code and tests. I reviewed the diff and test results.
Additional Information
Local verification:
ament_flake8,ament_pep257, andament_copyrighton both changed Python filesgit diff --check