Skip to content

Add per composable node log_level support - #531

Open
penww wants to merge 1 commit into
ros2:rollingfrom
penww:rolling
Open

Add per composable node log_level support#531
penww wants to merge 1 commit into
ros2:rollingfrom
penww:rolling

Conversation

@penww

@penww penww commented Apr 9, 2026

Copy link
Copy Markdown

Description

Fixes # (ros2/rclcpp#3091)

Is this user-facing behavior change?

No, this change add new parameter for ComposableNode, not affect the existing functions.

Did you use Generative AI?

Yes, partially with Claude Sonnet 4.6.

Additional Information

Example for per component log level feature enabled:

def generate_launch_description():
    return LaunchDescription([ComposableNodeContainer(
        name='component_demo_container',
        namespace='',
        package='rclcpp_components',
        executable='component_container',
        composable_node_descriptions=[
            ComposableNode(
                package='<PKG>',
                plugin='<PLUGIN>',
                log_level='DEBUG',  # component log level
            ),
        ],
        arguments=['--ros-args', '--log-level', 'INFO'],  # container log level
    )])

Related PR: ros2/rclcpp#3092, ros2/ros2cli#1212

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test would be ideal too.

Comment thread launch_ros/launch_ros/actions/load_composable_nodes.py Outdated
Comment thread launch_ros/launch_ros/actions/load_composable_nodes.py Outdated
Comment thread launch_ros/launch_ros/actions/load_composable_nodes.py Outdated
@mergify

mergify Bot commented Jul 2, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Signed-off-by: Peng Wang <penwang@qti.qualcomm.com>
@mergify

mergify Bot commented Aug 3, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@penww
penww requested a review from fujitatomoya August 3, 2026 09:57
@penww

penww commented Aug 3, 2026

Copy link
Copy Markdown
Author

Hi @fujitatomoya, thank you for the review. I've fixed the reported issues and updated the PR accordingly. I'd appreciate it if you could take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants