fix: emit SequenceAlloc::BufferTail for generated message sequences - #36
Open
rosterloh wants to merge 1 commit into
Open
fix: emit SequenceAlloc::BufferTail for generated message sequences#36rosterloh wants to merge 1 commit into
rosterloh wants to merge 1 commit into
Conversation
Pairs with the rosidl_runtime_rs change adding the `SequenceLayout` trait (`LayoutTail`) as a supertrait of `SequenceAlloc` (rosidl_buffer / ros2/rosidl#942). Message C sequences keep the plain 3-field layout, so generated message types implement `SequenceLayout` with `type LayoutTail = ();` (primitive sequences carry the 32-byte buffer tail). Refs ros2-rust/ros2_rust#659, ros2/rosidl#942
rosterloh
force-pushed
the
fix/sequence-buffer-tail
branch
from
July 27, 2026 08:04
85a1b70 to
5c0b9b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with the rosidl_runtime_rs change that adds the
BufferTailassociated type toSequenceAlloc(rosidl_buffer / ros2/rosidl#942). Message C sequences are not extended by #942, so generated message impls settype BufferTail = ();and stay 24 bytes, while primitive sequences carry the 32-byte buffer tail.Refs: ros2-rust/ros2_rust#659, ros2/rosidl#942