feat(hooks,attachment): implement propagation of AttachmentParent#163
Merged
TethysSvensson merged 14 commits intoJul 4, 2026
Merged
Conversation
…t-creation # Conflicts: # src/report_attachment/ref_.rs
Resolves the cargo fmt --check failure introduced when resolving the merge conflict in 5d9b372: my conflict resolution wrote the use line in multi-line form, but the import fits on one line so rustfmt wants it collapsed.
- CHANGELOG: drop stale `display_preformatted`/`debug_preformatted` references and tighten the entry (those methods were removed in rootcause-rs#148). - `ReportAttachmentRef::format_inner_with_parent`: bring docs up to par with `format_inner` / `format_inner_unhooked`, including an example. - `AttachmentParent.attachment_index`: document the pre-sort, pre-filter convention that `DefaultReportFormatter` upholds. - `tests/attachment_parent.rs`: extend coverage to `Appendix` placement. - Rename the leftover `style1` binding to `style`.
- Split the CHANGELOG entry: the `Option<AttachmentParent<'_>>` parameter on `AttachmentFormatterHook::display`/`debug` predates this PR. What's new is (a) `DefaultReportFormatter` now actually populates it instead of always passing `None`, and (b) the new `ReportAttachmentRef::format_inner_with_parent` method. Reflect both, with the behavior change under Changed. - Fix `form` -> `from` in the new example comment.
… wording Mirror the AttachmentParent cross-link from AttachmentFormatterHook::display's arg list onto debug's arg list. Rephrase AttachmentParent::attachment_index docs to call the index 'stable' and 'independent of' formatter sorting/filtering, making it clearer that filtered-out attachments do not shift indices.
The branch predated the 0.13.0 release, so merging main placed them in the already-released 0.13.0 section.
Define the index by what it is (indexing report.attachments() returns the attachment being formatted) instead of by what it is independent of, and drop the inline comment that restated the field docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds handling and creation of
AttachmentParentso thatAttachmentFormatterHookimpls can refer to their parent.Resolves #160