Skip to content

ci(deps): make fawltydeps audit member pyprojects + enable undeclared check #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julietshen wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −3
Open

ci(deps): make fawltydeps audit member pyprojects + enable undeclared check #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ jobs:
uv run pre-commit install --install-hooks
uv run pre-commit run --show-diff-on-failure --color=always --all-files

- name: Check for unused dependencies
run: uv tool run fawltydeps --check-unused --pyenv .venv
- name: Check for unused and undeclared dependencies
run: uv tool run fawltydeps --pyenv .venv

ui-quality:
runs-on: ubuntu-24.04
Expand Down
19 changes: 18 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,24 @@ known-first-party = ["osprey_worker", "osprey_async_worker", "osprey_rpc", "exam

[tool.fawltydeps]
code = ["osprey_worker/src", "osprey_async_worker/src", "osprey_rpc/src", "example_plugins/src"]
deps = ["pyproject.toml"]
# Include the workspace members so member-declared runtime deps (e.g. flask-cors on
# osprey_worker, aiodns/pycares on osprey_async_worker) aren't reported as undeclared.
deps = [
"pyproject.toml",
"osprey_rpc/pyproject.toml",
"osprey_worker/pyproject.toml",
"osprey_async_worker/pyproject.toml",
"example_plugins/pyproject.toml",
]
ignore_undeclared = [
# First-party: example_plugins uses a flat src layout, so these are its own
# top-level packages, not external dependencies.
"async_sinks",
"register_async_plugins",
"udfs",
# Typing-only import guarded by TYPE_CHECKING.
"_typeshed",
]
ignore_unused = [
# Type stubs: used by mypy, never imported directly
"types-cachetools",
Expand Down
Loading