feat: 670 per reviewer skip

[calebmcquaid]

Context & Requests for Reviewers

Part 3 of 3 for #670. Previously, skipping a job just released the lock. The job came right back to the same reviewer, and skip was two separate client calls (logSkip + releaseJobLock) that could partially fail.

• Skip is now one server-side operation: logSkip atomically logs the skip, records the job in a per-reviewer Redis skip set (sorted set scored by expiry, with a TTL backstop), and releases the lock. The client's separate ReleaseJobLock call is removed.
• Dequeue steps past skipped jobs for that reviewer only: the scan holds skipped jobs aside under the reviewer's lock token and releases them in a finally, so they return to the shared pool immediately for everyone else.
• getNextJob now uses block: false, so a drained queue returns null immediately instead of long-polling and hanging the reviewer's request.
• UI: skip failures show a retry modal instead of failing silently; when no reviewable job remains (drained, or everything left is skipped by this reviewer), the reviewer is redirected to the queue list instead of a perpetual spinner.

Review focus: the held-aside-then-release pattern in dequeueNextJobWithLock, particularly lock-token semantics (the token is the reviewer's userId) and what happens if the release in finally partially fails.

Tests

• QueueOperations.reviewerSkips.test.ts — skip set recording/expiry, dequeue filtering per reviewer, held-aside jobs released for other reviewers.

Checklist

• If you changed anything user-facing (i.e. user interface or APIs):
  Did you update the CHANGELOG.md and related docs?

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b2fca305-8d52-4335-9f80-ed2e1ac52e7e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch caleb/670-per-reviewer-skip

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[taobojlen]

are you adding useCallback in response to an observed performance issue, or is it hypothetical?

[taobojlen]

should we not have selectedRelatedActionsSetter in the dependency array, too?

[taobojlen]

why does this dependency array only have one of the functions?

[taobojlen]

(as in another PR) we should probably decide how we want to handle the changelog, i.e. writing to it per-PR or manually writing it all once in a while

cc @cassidyjames

[taobojlen]

hmm, how come we only skip for 30 minutes?

i guess in general -- what's the user story we imagine when someone skips a job? is it "i am not qualified to review this", "this is a hard job and i don't wanna deal with it / lower my average handling time by taking it", or something else? cc @julietshen

[Copilot]

Pull request overview

This PR updates the manual review “skip” flow so skipping is handled as a single server-side operation and so dequeueing can transparently step past jobs a given reviewer recently skipped (without hiding those jobs from other reviewers).

Changes:

• Added per-reviewer skip tracking in Redis and updated dequeue to hold skipped jobs aside under the reviewer’s lock, then release them back to the shared pool.
• Updated dequeue behavior to avoid long-poll hangs by using block: false when calling BullMQ getNextJob.
• Simplified the client skip flow to a single logSkip mutation and improved UX when no reviewable job remains.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
server/services/manualReviewToolService/modules/QueueOperations.ts	Implements per-reviewer skip filtering/hold-aside behavior and Redis skip-set helpers; updates getNextJob usage.
server/services/manualReviewToolService/modules/QueueOperations.reviewerSkips.test.ts	Adds coverage for skip-set recording/expiry and per-reviewer dequeue filtering behavior.
server/services/manualReviewToolService/manualReviewToolService.ts	Makes logSkip also record the per-reviewer skip and release the lock server-side.
client/src/webpages/dashboard/mrt/manual_review_job/ManualReviewJobReview.tsx	Removes separate ReleaseJobLock mutation and updates skip UX/redirect behavior.
client/src/graphql/generated.ts	Removes the generated ReleaseJobLock operation artifacts.
CHANGELOG.md	Adds an unreleased “Review Console” changelog entry for the new skip behavior (needs scope correction).

[taobojlen]

i think this needs a rebase 😅 this is too big to review and includes lots of unrelated changes!

github's native stacks feature might be useful!