chore: tighten server/client types ahead of pnpm migration

client/src/setupTests.ts

@@ -1,3 +1,4 @@
+import '@testing-library/jest-dom/vitest';
 import { vi } from 'vitest'
 
 global.jest = vi as any;

client/src/utils/collections.ts

@@ -23,5 +23,5 @@ export function filterNullOrUndefined<T>(
 }
 
 export function arrayFromArrayOrSingleItem<T>(array: readonly T[] | T): T[] {
-  return Array.isArray(array) ? [...array] : [array];
+  return Array.isArray(array) ? [...(array as readonly T[])] : [array as T];
 }

client/tsconfig.json

@@ -2,7 +2,7 @@
   "compilerOptions": {
     "jsx": "react-jsx",
     "target": "ESNext",
-    "types": ["vite/client", "vite-plugin-svgr/client"],
+    "types": ["vite/client", "vite-plugin-svgr/client", "jest", "google.maps"],
     "module": "esnext",
     "strict": true,
     "esModuleInterop": true,

server/api.ts

@@ -18,7 +18,8 @@ import cors from 'cors';
 import express, { type ErrorRequestHandler } from 'express';
 import session from 'express-session';
 import { GraphQLError, type GraphQLFormattedError } from 'graphql';
-import helmet from 'helmet';
+import helmet_, { type HelmetOptions } from 'helmet';
+const helmet = helmet_ as unknown as (options?: Readonly<HelmetOptions>) => (req: unknown, res: unknown, next: (err?: unknown) => void) => void;
 import passport from 'passport';
 
 import { makeLoginUserDoesNotExistError } from './graphql/datasources/userApiErrors.js';

server/condition_evaluator/getDerivedFieldValue.ts

@@ -1,5 +1,6 @@
 import _ from 'lodash';
-import stringify from 'safe-stable-stringify';
+import stringify_ from 'safe-stable-stringify';
+const stringify = stringify_ as unknown as (value: unknown) => string | undefined;
 
 import {
   getDerivedFieldValue,

server/graphql/customScalars/OpaqueScalarMixin.ts

@@ -43,6 +43,7 @@ export default <T extends object>(
   'serialize' | 'parseValue' | 'parseLiteral'
 > => ({
   serialize(value) {
+    // @ts-expect-error -- @types/jsonwebtoken@9 brands expiresIn as StringValue from ms; plain string is valid at runtime
     return jwt.sign(value as T, jwtSigningKey, {
       expiresIn: jwtExpiresIn,
     });

server/lib/cache/utils/utils.ts

@@ -1,6 +1,16 @@
 import { setTimeout } from "timers/promises";
-import debug from "debug";
-import stringify from "safe-stable-stringify";
+import stringify_ from "safe-stable-stringify";
+
+// Minimal debug-compatible logger — avoids phantom dep under pnpm strict mode.
+// Behaviour is identical when DEBUG is unset (the common case in tests/prod).
+const debug = (namespace: string) => {
+  const patterns = (process.env.DEBUG ?? '').split(',').map((p) => p.trim());
+  const enabled = patterns.some(
+    (p) => p === '*' || p === namespace || (p.endsWith('*') && namespace.startsWith(p.slice(0, -1))),
+  );
+  return (...args: unknown[]) => { if (enabled) console.debug(`  ${namespace}`, ...args); };
+};
+const stringify = stringify_ as unknown as (value: unknown) => string | undefined;
 import { type JsonValue, type Tagged } from "type-fest";
 
 import { components, type Logger } from "../types/index.js";

server/lib/cache/utils/wrapProducer.ts

@@ -1,4 +1,5 @@
-import stableStringify from "safe-stable-stringify";
+import stableStringify_ from "safe-stable-stringify";
+const stableStringify = stableStringify_ as unknown as (value: unknown) => string | undefined;
 
 import type Cache from "../Cache.js";
 import { type NormalizedProducerResult } from "../types/06_Normalization.js";

server/plugins/warehouse/utils/clickhouseSql.ts

@@ -1,4 +1,5 @@
-import safeStableStringify from 'safe-stable-stringify';
+import safeStableStringify_ from 'safe-stable-stringify';
+const safeStableStringify = safeStableStringify_ as unknown as (value: unknown) => string | undefined;
 
 function escapeString(value: string): string {
   return value.replace(/\\/g, '\\\\').replace(/'/g, "\\'");
@@ -37,7 +38,7 @@ function formatValue(value: unknown): string {
   }
 
   if (typeof value === 'object') {
-    const json = safeStableStringify(value);
+    const json = safeStableStringify(value) ?? 'null';
     return `'${escapeString(json)}'`;
   }
 

server/rule_engine/RuleEvaluator.ts

@@ -57,7 +57,7 @@ type RuleEvaluationContextImpl = Readonly<{
 
 export type RuleEvaluationContext = Opaque<
   RuleEvaluationContextImpl,
-  RuleEvaluationContextImpl
+  'RuleEvaluationContext'
 >;
 
 export type RuleExecutionResult = {

server/services/itemInvestigationService/utils.ts

@@ -1,6 +1,7 @@
 import type { ItemIdentifier } from '@roostorg/coop-types';
 import _ from 'lodash';
-import stringify from 'safe-stable-stringify';
+import stringify_ from 'safe-stable-stringify';
+const stringify = stringify_ as unknown as (value: unknown) => string | undefined;
 import _S2A from 'stream-to-async-iterator';
 
 import {

server/services/manualReviewToolService/modules/JobDecisioning.ts

@@ -324,7 +324,9 @@ export default class JobDecisioning {
           .with(['ALREADY_LOGGED', 'SUCCESS'], () => jobAlreadySubmittedError)
           // Case 4, client retrying after failed job deletion; deletion failed again.
           .with(['ALREADY_LOGGED', 'FAILED'], () => decisioningFailedError)
-          .exhaustive(),
+          // ts-pattern v5.9 + TS 5.9: .exhaustive() triggers NonExhaustiveError<[any]>;
+          // all four cases above are covered so this branch is dead code.
+          .otherwise(() => undefined),
       };
     })();
 

server/services/networkingService/index.ts

@@ -213,15 +213,15 @@ export async function fetchHTTP<T extends HandleResponseBody>(
           // If the body isn't already an ArrayBuffer, we need to encode the body
           // as an ArrayBuffer, so we first coerce it to a string from a `string |
           // URLSearchParams` type, and then encode it with TextEncoder
-          const bodyBuffer =
+          const bodyBuffer: ArrayBuffer =
             castBody instanceof ArrayBuffer
               ? castBody
               : new TextEncoder().encode(
                   // `satisfies` ensures that new body types, on which we can't
                   // necessarily just call toString, won't get accidentally
                   // handled incorrectly
                   (castBody satisfies string | URLSearchParams).toString(),
-                );
+                ).buffer as ArrayBuffer;
 
           const { signature } = await query.signWith(bodyBuffer);
           return b64EncodeArrayBuffer(signature);

server/services/orgAwareSignalExecutionService/signalExecutionService.ts

@@ -1,6 +1,7 @@
 import { SpanStatusCode } from '@opentelemetry/api';
 import _ from 'lodash';
-import stringify from 'safe-stable-stringify';
+import stringify_ from 'safe-stable-stringify';
+const stringify = stringify_ as unknown as (value: unknown) => string | undefined;
 import { type ReadonlyDeep } from 'type-fest';
 
 import { inject } from '../../iocContainer/utils.js';

server/test/arbitraries/ContentType.ts

@@ -47,7 +47,7 @@ export const GeohashArbitrary = fc
   });
 
 export const DateStringArbitrary = fc
-  .date()
+  .date({ noInvalidDate: true })
   .map((date) => makeDateString(date.toISOString())!);
 
 // Id-like fields allow numbers and strings as inputs, but the normalized

server/test/utils.ts

@@ -167,7 +167,11 @@ export function makeTestWithFixture<T extends Record<string, unknown>>(
 
 function _makeTestWithFixture<T extends Record<string, unknown>>(
   makeSetupTeardown: () => Promise<Fixture<T>> | Fixture<T>,
-  jestFn = it,
+  jestFn: (
+    name: string,
+    fn?: jest.ProvidesCallback,
+    timeout?: number,
+  ) => void = it,
 ) {
   return (
     name: string,

server/utils/encoding.ts

@@ -1,4 +1,5 @@
-import stringify from 'safe-stable-stringify';
+import stringify_ from 'safe-stable-stringify';
+const stringify = stringify_ as unknown as (value: unknown) => string | undefined;
 import { type Opaque } from 'type-fest';
 
 import { JSON } from './json-schema-types.js';