Skip to content

Rename environment variable ITEM_INVESTIGATION_AND_STRIKES_ENABLED to SCYLLA_ENABLED - #1268

Merged
cassidyjames merged 1 commit into
mainfrom
emelia/rename-env-var-for-release
Sep 19, 2026
Merged

cassidyjames merged 1 commit into
mainfrom
emelia/rename-env-var-for-release

Conversation

@ThisIsMissEm

@ThisIsMissEm ThisIsMissEm commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Context & Requests for Reviewers

This prevents an unreleased feature (#889 / #918) from being released with an environment variable that we'd be renaming in #1235 — the only "breaking" change there for this feature would then be dropping yes and no as supported boolean values, but that's happening across all the boolean flags.

Tests

standard CI/CD

(Optional) Rollout Plan

n/a

Checklist

Only check items that apply to this PR; leave the rest unchecked.

  • If you changed anything user-facing (i.e. user interface or APIs):
    Did you update related docs? Original PR didn't document new environment variable, so leaving as undocumented for now.

  • If the change is notable (refer to Keep a Changelog conventions):
    Did you update CHANGELOG.md?

  • If you changed db/src/scripts/** and used CREATE TABLE, ADD COLUMN, or ALTER COLUMN:
    Are as many columns marked NOT NULL as possible? If some columns can sometimes be null depending on other columns, are there CHECK constraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?

  • If you added a new signal in server/services/signalsService/signals/**:
    Did you classify every error case as a permanent error (SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be a SignalPermanentError.


Summary by cubic

Renames the ITEM_INVESTIGATION_AND_STRIKES_ENABLED environment variable to SCYLLA_ENABLED to match the SCYLLA_* connection settings it controls. The old variable name is no longer read, so anyone who set it must update their environment; the default remains enabled when unset, so an unupdated config silently falls back to Scylla enabled. No other behavior changes.

Written for commit 8733d05. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Changed
    • Renamed the Scylla feature toggle environment variable to SCYLLA_ENABLED.
    • Scylla remains enabled by default; setting SCYLLA_ENABLED=false disables the feature.
    • Updated configuration guidance and related documentation to reflect the new variable name.

@ThisIsMissEm
ThisIsMissEm requested a review from a team as a code owner September 19, 2026 02:03
@coderabbitai

coderabbitai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: roostorg/coop/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0a022c76-2530-4ff1-bf26-51362ace22cf

📥 Commits

Reviewing files that changed from the base of the PR and between 3f32768 and 8733d05.

📒 Files selected for processing (5)
  • CHANGELOG.md
  • server/.env.example
  • server/iocContainer/index.ts
  • server/scylla/noOpScylla.test.ts
  • server/scylla/noOpScylla.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The Scylla feature flag was renamed to SCYLLA_ENABLED. Runtime wiring, environment configuration, log messages, documentation comments, test descriptions, and the changelog now use the new name.

Changes

Scylla flag rename

Layer / File(s) Summary
Runtime flag wiring
server/.env.example, server/iocContainer/index.ts
The environment example and dependency-injection factories use SCYLLA_ENABLED for Scylla and user-strike gating.
Supporting references
CHANGELOG.md, server/scylla/noOpScylla.ts, server/scylla/noOpScylla.test.ts
The changelog, documentation comments, and test descriptions use SCYLLA_ENABLED.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: sunilatlas

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: renaming the Scylla environment variable.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ThisIsMissEm
ThisIsMissEm force-pushed the emelia/rename-env-var-for-release branch from 00064c5 to 8733d05 Compare September 19, 2026 02:03
@ThisIsMissEm ThisIsMissEm added this to the 1.1.0 milestone Sep 19, 2026
itemInvestigationAndStrikesEnabled(
process.env.ITEM_INVESTIGATION_AND_STRIKES_ENABLED,
),
itemInvestigationAndStrikesEnabled(process.env.SCYLLA_ENABLED),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deliberately kept the existing name as this method disappears entirely in #1235, and as it is, it's not using isEnvTrue from server/iocContainer/utils.ts and negating it, but instead implementing the inverse — this is why I flattened all env vars to Env.schema.boolean() in #1235, to prevent issues like this.

@cassidyjames
cassidyjames merged commit 4233d94 into main Sep 19, 2026
18 checks passed
@cassidyjames
cassidyjames deleted the emelia/rename-env-var-for-release branch September 19, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants