Rename environment variable ITEM_INVESTIGATION_AND_STRIKES_ENABLED to SCYLLA_ENABLED - #1268
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: roostorg/coop/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Scylla feature flag was renamed to ChangesScylla flag rename
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
00064c5 to
8733d05
Compare
| itemInvestigationAndStrikesEnabled( | ||
| process.env.ITEM_INVESTIGATION_AND_STRIKES_ENABLED, | ||
| ), | ||
| itemInvestigationAndStrikesEnabled(process.env.SCYLLA_ENABLED), |
There was a problem hiding this comment.
I've deliberately kept the existing name as this method disappears entirely in #1235, and as it is, it's not using isEnvTrue from server/iocContainer/utils.ts and negating it, but instead implementing the inverse — this is why I flattened all env vars to Env.schema.boolean() in #1235, to prevent issues like this.
Context & Requests for Reviewers
This prevents an unreleased feature (#889 / #918) from being released with an environment variable that we'd be renaming in #1235 — the only "breaking" change there for this feature would then be dropping
yesandnoas supported boolean values, but that's happening across all the boolean flags.Tests
standard CI/CD
(Optional) Rollout Plan
n/a
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update related docs? Original PR didn't document new environment variable, so leaving as undocumented for now.
If the change is notable (refer to Keep a Changelog conventions):
Did you update CHANGELOG.md?
If you changed
db/src/scripts/**and usedCREATE TABLE,ADD COLUMN, orALTER COLUMN:Are as many columns marked
NOT NULLas possible? If some columns can sometimes be null depending on other columns, are thereCHECKconstraints capturing those relationships, and are these also reflected using unions in the associated Kysely types?If you added a new signal in
server/services/signalsService/signals/**:Did you classify every error case as a permanent error (
SignalPermanentError, no retry) or a normal error (retryable)? Any case where the signal can't determine a score should be aSignalPermanentError.Summary by cubic
Renames the
ITEM_INVESTIGATION_AND_STRIKES_ENABLEDenvironment variable toSCYLLA_ENABLEDto match theSCYLLA_*connection settings it controls. The old variable name is no longer read, so anyone who set it must update their environment; the default remains enabled when unset, so an unupdated config silently falls back to Scylla enabled. No other behavior changes.Written for commit 8733d05. Summary will update on new commits.
Summary by CodeRabbit
SCYLLA_ENABLED.SCYLLA_ENABLED=falsedisables the feature.