-
Notifications
You must be signed in to change notification settings - Fork 46
Consistently use build/ directory for built code #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,5 @@ coop.code-workspace | |
| server/coverage | ||
| **/node_modules/ | ||
| server/reports | ||
| **/transpiled/ | ||
| models-service | ||
| **/build | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,6 @@ yarn-error.log* | |
| db/build | ||
| .idea/ | ||
|
|
||
| transpiled | ||
| build/ | ||
| .eslintcache | ||
| *.tsbuildinfo | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| node_modules/ | ||
| build/ | ||
| .eslintcache | ||
| transpiled/ | ||
| reports | ||
|
|
||
| # Playwright e2e artifacts | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,12 @@ | |
| "type": "module", | ||
| "version": "2.4.0", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we should bump the version given the change.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wasn't sure how version is happening for the package, hence leaving it. Normally I use release tooling that handles versioning automatically. What would we define the version bump as? major, minor or patch?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. patch I would guess 🤔 it does change license and exports, but may be ok. |
||
| "description": "Shared TypeScript types for Coop: schema primitives, signal data maps, and integration contracts.", | ||
| "module": "transpiled/index.js", | ||
| "typings": "./transpiled/index.d.ts", | ||
| "module": "build/index.js", | ||
| "typings": "./build/index.d.ts", | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "prepublishOnly": "npm run build", | ||
| "test": "npm run build && node --test transpiled/test_scripts/" | ||
| "test": "npm run build && node --test build/test_scripts/" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
|
|
@@ -17,9 +17,9 @@ | |
| }, | ||
| "author": "Roostorg", | ||
| "files": [ | ||
| "transpiled" | ||
| "build" | ||
| ], | ||
| "license": "ISC", | ||
| "license": "Apache-2.0", | ||
|
ThisIsMissEm marked this conversation as resolved.
|
||
| "devDependencies": { | ||
| "@types/node": "^20.3.1", | ||
| "typescript": "^4.9.3" | ||
|
|
@@ -29,8 +29,8 @@ | |
| }, | ||
| "exports": { | ||
| ".": { | ||
| "import": "./transpiled/index.js", | ||
| "types": "./transpiled/index.d.ts" | ||
| "import": "./build/index.js", | ||
| "types": "./build/index.d.ts" | ||
| } | ||
| }, | ||
| "dependencies": { | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.