fix(client): keep the blurred video inside its rounded frame - #1170
Draft
serendipty01 wants to merge 1 commit into
Draft
serendipty01 wants to merge 1 commit into
serendipty01 wants to merge 1 commit into
Conversation
react-player emits a default 640x360 wrapper, so the blurred-video panel in a manual review job spilled past its rounded/shadowed border, and the Infinity defaults produced invalid 'max-width: Infinity'. Clip the wrapper and only pass finite max-* styles. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
fixes #1227
react-player's wrapper<div>defaults to a fixed 640x360 and forwardsstylestraight to it, so it overflows (or gets clipped) whenever the review panel is narrower than 640px. Make the player fill the container width instead, capped by any caller-supplied max-*.Tests
manually tested
blurred-video-overflow-fix-01.mp4
blurred-video-overflow-repro-02.mp4
Checklist
Only check items that apply to this PR; leave the rest unchecked.
If you changed anything user-facing (i.e. user interface or APIs):
Did you update related docs?
If the change is notable (refer to Keep a Changelog conventions):
Did you update CHANGELOG.md?