Migrate to facebook/content-review-filters

[cassidyjames]

As mentioned in #193 and our April 2 issue triage call, we should migrate our existing wellness features to the @facebook/content-review-filters package.

[cassidyjames]

@lswartsenburg I see from #193 that you demoed these in the run-content-filters repo; any interest or bandwidth to take a look at this issue? 😅 If not, nbd but I thought it was worth checking.

[maarkN]

Hi @cassidyjames,

I did like to work on this issue. Of course if @lswartsenburg not started to look it.

[cassidyjames]

@maarkN that sounds fine to me! Thanks!

[maarkN]

Hi @cassidyjames, one question before I start, about blur intensity.

Coop's blur slider goes 0–6 and maps to Tailwind classes up to blur-2xl (40px): NCMECMediaViewer.tsx

The package's blur is 0–1 multiplied by 10px, so it tops out at 10px: FilterPreferenceUtils

Levels 0–2 map directly (the org default is level 2, 8px), but levels 3–6 (12–40px) have no equivalent. Which would you prefer?

1. Cap at 10px: levels 3–6 would all look the same.
2. Rescale 0–6 onto 0–10px: every level above 0, including the default, gets lighter than today.
3. Keep today's intensities: this needs values outside the package's 0–1 range, probably through a change upstream.

[cassidyjames]

@maarkN we chatted briefly in Discord, but for the record, it looks like you might be able to pass in a value greater than 1, so we could map the existing preferences to the equivalent amount of blur. If not, I'm not sure if it's acceptable to reduce the maximum blur that users/orgs have set as their wellness settings—even if 40px does seem pretty extreme to me. :) It might be worth screenshotting some comparisons (using innocuous example images) so we can compare.

[maarkN]

Opened #1186 with the first part: the wellness filters now go through a single helper, today's blur intensities are preserved, hovering a video unblurs it (closes #524), and the color scheme applies to videos in the review console.

The second part, rendering through content-review-filters, is on hold for now. Importing the package initializes WebGL at module load, which breaks browsers without WebGL2 and our jsdom tests (facebook/content-review-filters#36), and blur is capped at 10px through the supported path while Coop goes up to 40px (facebook/content-review-filters#35).

I'm waiting for an update to content-review-filters with the blur config option before picking the second PR up.