Skip to content
This repository was archived by the owner on Jan 24, 2020. It is now read-only.

notify: keep rescaled images around - #5

Open
mathstuf wants to merge 1 commit into
rohieb:masterfrom
mathstuf:keep-file
Open

mathstuf wants to merge 1 commit into
rohieb:masterfrom
mathstuf:keep-file

Conversation

@mathstuf

@mathstuf mathstuf commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

It seems that at least dunst removes the image from the notification if
the file disappears.

It seems that at least dunst removes the image from the notification if
the file disappears.
@mathstuf

mathstuf commented Apr 4, 2016

Copy link
Copy Markdown
Contributor Author

Split from #4 in case it isn't needed.

@rohieb

rohieb commented Apr 27, 2016

Copy link
Copy Markdown
Owner

I still don't see any sense in tmpfiles not getting cleaned up any time, even in .cache directories. But on second thought, I suggest that we keep the tmpfile around so dunst can display it, but write to the same tmpfile when a new notification is displayed on track change. We can then delete the tmpfile in mp.register_event("shutdown", …).

@mathstuf

Copy link
Copy Markdown
Contributor Author

I think that would just make all album images appear the same. I'm fine with a local patch until dunst gets a proper fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants