Skip to content

Trigger the ssr rewrite warning at globalization time. - #21874

Closed
ppedrot wants to merge 1 commit into
rocq-prover:masterfrom
ppedrot:rw-warning-at-glob-time
Closed

ppedrot wants to merge 1 commit into
rocq-prover:masterfrom
ppedrot:rw-warning-at-glob-time

Conversation

@ppedrot

@ppedrot ppedrot commented Apr 2, 2026

Copy link
Copy Markdown
Member

Instead of doing that at runtime, which clutters the output with irrelevant data, we do this at globalization time using an already available mechanism in TACTIC EXTEND.

Note that we lose the quickfix info as there is no way to make a Deprecation.t with a quickfix in the API, should that be fixed first? cc @proux01 and @gares

Instead of doing that at runtime, which clutters the output with irrelevant
data, we do this at globalization time using an already available mechanism
in TACTIC EXTEND.
@ppedrot ppedrot added this to the 9.3+rc1 milestone Apr 2, 2026
@ppedrot ppedrot added kind: fix This fixes a bug or incorrect documentation. request: full CI Use this label when you want your next push to trigger a full CI. labels Apr 2, 2026
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 2, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor

This also changes the warning name and message though.

Warning: Tactic Notation rewrite (ssrrewriteargs) (ssrclauses) is deprecated since 9.3.
The 'rewrite' tactic has been renamed 'rw'.
[deprecated-tactic-notation-since-9.3,deprecated-since-9.3,deprecated-tactic-notation,deprecated,default]

instead of

Warning: The 'rewrite' tactic has been renamed 'rw'.
[rewrite-rw,deprecated-since-9.3,deprecated,default]

@ppedrot

ppedrot commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

I guess that we could tweak the DEPRECATED clause to accept arbitrary warnings if we want this...

@SkySkimmer
SkySkimmer requested a review from a team April 2, 2026 13:19
@SkySkimmer

Copy link
Copy Markdown
Contributor

Best I can come up with is #21877

@SkySkimmer SkySkimmer closed this Apr 2, 2026
@coqbot-app coqbot-app Bot removed this from the 9.3+rc1 milestone Apr 2, 2026
@ppedrot
ppedrot deleted the rw-warning-at-glob-time branch May 27, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: fix This fixes a bug or incorrect documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants