Conversation
Instead of doing that at runtime, which clutters the output with irrelevant data, we do this at globalization time using an already available mechanism in TACTIC EXTEND.
Contributor
|
This also changes the warning name and message though. instead of |
Member
Author
|
I guess that we could tweak the DEPRECATED clause to accept arbitrary warnings if we want this... |
Contributor
|
Best I can come up with is #21877 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing that at runtime, which clutters the output with irrelevant data, we do this at globalization time using an already available mechanism in TACTIC EXTEND.
Note that we lose the quickfix info as there is no way to make a Deprecation.t with a quickfix in the API, should that be fixed first? cc @proux01 and @gares