Conversation
Collaborator
|
What is the cslib error? |
Collaborator
|
also there's a merge conflict |
theostos
force-pushed
the
pr/universe-instances
branch
from
September 8, 2026 11:47
2dc7529 to
96ff81d
Compare
theostos
marked this pull request as draft
September 8, 2026 14:10
Contributor
Author
|
sorry about that, I'm not able to reproduce the problem, I may have mixed this branch with another one |
Represent each translated universe instance as a complete expression over the Lean universe parameters. This keeps reference instances aligned with declaration contexts when successor and maximum levels require synthesized Rocq universes.
theostos
force-pushed
the
pr/universe-instances
branch
from
September 8, 2026 21:43
96ff81d to
a8e4215
Compare
Collaborator
|
This PR seems like an optimization rather than a bugfix as it avoids exposing unused universes in the interface of references (ie in their instances) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The importer previously formed Rocq universe instances from an implicit prefix of Lean parameters and a separately stored suffix for synthesized
max/succlevels. It now stores the complete instance recipe and declares only directly used source levels plus synthesized algebraic levels; this fixes the universe-constraint failure at cslib'sInt64.toInt_minValue.