Skip to content

BALLING into main - #263

Merged
Jetblackdragon merged 28 commits into
mainfrom
balling
Jun 8, 2026
Merged

BALLING into main#263
Jetblackdragon merged 28 commits into
mainfrom
balling

Conversation

@RobototesProgrammers

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'Balling' mode for basketball hoop scoring, updates CTRE Phoenix 6 and PhotonLib dependencies, and implements a currently-disabled swerve module slip detection algorithm. It also refines controls and turret bindings, and disables field boundary clamping when Balling mode is active. Feedback on the changes highlights two critical issues: first, ballingDistanceData is incorrectly populated into standard maps instead of balling-specific maps in LauncherConstants.java, which will cause lookup failures; second, a potential NullPointerException exists in Controls.java because s.flywheels is not checked for null before retrieving its target speed.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main/java/frc/robot/util/tuning/LauncherConstants.java
Comment thread src/main/java/frc/robot/Controls.java Outdated
Jetblackdragon
Jetblackdragon previously approved these changes Jun 8, 2026
@Jetblackdragon
Jetblackdragon merged commit 36a8fbd into main Jun 8, 2026
2 checks passed
@Jetblackdragon
Jetblackdragon deleted the balling branch June 8, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants