Skip to content

Worlds Branch (slip fliter disabled) - #254

Merged
koolpoolo merged 18 commits into
mainfrom
Issue250
Jun 1, 2026
Merged

Worlds Branch (slip fliter disabled)#254
koolpoolo merged 18 commits into
mainfrom
Issue250

Conversation

@RobototesProgrammers

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the pose-velocity blending mechanism with a dual-mode slip filter to better compensate for robot defense and wheel slip. It introduces hysteresis for the robot movement gate and the slip tracking mode to prevent rapid toggling. A logic error was identified in the slipFastMode hysteresis implementation, where the state would incorrectly reset when the slip magnitude was between the entry and exit thresholds.

Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java Outdated
@jamesdooley4 jamesdooley4 changed the title Issue250 Issue250: Update LaunchCalculator to use slip filter to handle vision / wheel divergence Apr 28, 2026
jamesdooley4
jamesdooley4 previously approved these changes Apr 29, 2026

@jamesdooley4 jamesdooley4 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments mostly about things to think more about / test before merging to main.

Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
@Jetblackdragon Jetblackdragon changed the title Issue250: Update LaunchCalculator to use slip filter to handle vision / wheel divergence Worlds Branch (slip fliter disabled) May 19, 2026
Comment thread src/main/java/frc/robot/Controls.java
Comment thread src/main/java/frc/robot/Controls.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java Outdated
Comment thread src/main/java/frc/robot/Controls.java Outdated
Comment thread src/main/java/frc/robot/Controls.java Outdated
@RobototesProgrammers

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a wheel slip detection algorithm and a hysteresis gate for robot movement in LaunchCalculator.java, updates launcher distance constants, adds a turretSkipped toggle in Controls.java, and updates vendor dependencies. Feedback on these changes includes removing a redundant dependency in build.gradle, refreshing Phoenix 6 status signals before reading them, initializing lastModuleVelocity with current velocities to prevent false slip detection on startup, correcting the SLIP_CURRENT_THRESHOLD constant, and ensuring turret subsystem commands are disabled when turretSkipped is active.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread build.gradle Outdated
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/subsystems/launcher/LaunchCalculator.java
Comment thread src/main/java/frc/robot/Controls.java
@koolpoolo
koolpoolo merged commit 4e1601e into main Jun 1, 2026
2 checks passed
@koolpoolo
koolpoolo deleted the Issue250 branch June 1, 2026 23:46
@koolpoolo
koolpoolo restored the Issue250 branch June 1, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add variable low-pass filter for wheel slip detection in LaunchCalculator

6 participants