Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the pose-velocity blending mechanism with a dual-mode slip filter to better compensate for robot defense and wheel slip. It introduces hysteresis for the robot movement gate and the slip tracking mode to prevent rapid toggling. A logic error was identified in the slipFastMode hysteresis implementation, where the state would incorrectly reset when the slip magnitude was between the entry and exit thresholds.
jamesdooley4
left a comment
There was a problem hiding this comment.
Comments mostly about things to think more about / test before merging to main.
509e9e8 to
bceb321
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a wheel slip detection algorithm and a hysteresis gate for robot movement in LaunchCalculator.java, updates launcher distance constants, adds a turretSkipped toggle in Controls.java, and updates vendor dependencies. Feedback on these changes includes removing a redundant dependency in build.gradle, refreshing Phoenix 6 status signals before reading them, initializing lastModuleVelocity with current velocities to prevent false slip detection on startup, correcting the SLIP_CURRENT_THRESHOLD constant, and ensuring turret subsystem commands are disabled when turretSkipped is active.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
No description provided.