Add numeric label scrubbing and interaction coverage - #122
Merged
robbietilton merged 1 commit intoSep 24, 2026
Merged
Conversation
robbietilton
added a commit
that referenced
this pull request
Sep 24, 2026
…s they were On top of #122: dragging snaps to whole numbers in Canvas Size, Image Size, the Type bar's size, tracking and leading, and the transform bar (typing still takes decimals). New Canvas width and height aren't draggable. The UI tests stay out of CI and the scheme, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Merged, thanks — label scrubbing feels great. A few changes on main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
main: 436 tests passed, 0 failed.Known pre-existing issue
In Image Size, choose Inches with Resample enabled, enter an invalid negative Resolution such as
-5, then correct it to72without closing the sheet. The pixel dimensions can grow unexpectedly. This also occurs in the v1.2.10 release. This PR prevents scrubbing the dimension labels while the physical resolution is invalid; it does not change the existing resolution-recovery behavior.