Skip to content

Add numeric label scrubbing and interaction coverage - #122

Merged
robbietilton merged 1 commit into
robbietilton:mainfrom
Fe4rlessCloak:numeric-input-slider
Sep 24, 2026
Merged

robbietilton merged 1 commit into
robbietilton:mainfrom
Fe4rlessCloak:numeric-input-slider

Conversation

@Fe4rlessCloak

Copy link
Copy Markdown
Contributor

Summary

  • Drag numeric labels horizontally to adjust their adjacent values. Numeric fields still accept typed input when clicked.
  • Apply scrubbing across New Canvas, tool controls, layer opacity, and sizing and adjustment sheets, using each control’s existing limits.
  • Let the empty canvas leave cursor control to the New Canvas form, while preserving tool cursors when a document is open.
  • Add UI tests for dragging, limits, typing, opacity undo, Canvas Size, and Image Size. Run UI tests serially in CI.

Testing

  • Full local Xcode suite after rebasing onto main: 436 tests passed, 0 failed.
  • Cursor callbacks are covered by tests. Pointer appearance on hover, leave, and release outside a label should be checked with the actual macOS pointer.

Known pre-existing issue

In Image Size, choose Inches with Resample enabled, enter an invalid negative Resolution such as -5, then correct it to 72 without closing the sheet. The pixel dimensions can grow unexpectedly. This also occurs in the v1.2.10 release. This PR prevents scrubbing the dimension labels while the physical resolution is invalid; it does not change the existing resolution-recovery behavior.

robbietilton added a commit that referenced this pull request Sep 24, 2026
…s they were

On top of #122: dragging snaps to whole numbers in Canvas Size, Image Size, the Type bar's size,
tracking and leading, and the transform bar (typing still takes decimals). New Canvas width and height
aren't draggable. The UI tests stay out of CI and the scheme, as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robbietilton
robbietilton merged commit 03cde4d into robbietilton:main Sep 24, 2026
1 check passed
@robbietilton

Copy link
Copy Markdown
Owner

Merged, thanks — label scrubbing feels great. A few changes on main:

  • Dragging snaps to whole numbers in Canvas Size, Image Size, the Type bar (size, tracking, leading) and the transform bar (X, Y, W, H, scale, angle). Typing still accepts decimals.
  • New Canvas width and height aren't draggable.
  • Left the UI tests out: I'm keeping CI to the unit tests, so the test plan, scheme and workflow changes aren't included. Your unit test updates are in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants