fix(ui): inset the bar line one column from the left edge - #27
Merged
Merged
Conversation
The bar's first cell sat hard against the terminal's left edge, where the glyph and job id read as if they had been clipped. The inset belongs to the bar rather than to each mode, so `render` pads the line it prints and builds every mode line — status, notices, help — for the columns left over, which keeps the status line's drop-to-fit logic honest about the pane width. The accent rule still spans edge to edge: it is a fence, and a gap at its end would read as a break in it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GDCMtWbUps1fu3JMhyh5y6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bar's first cell sat hard against the terminal's left edge, so the
severity glyph and job id read as if they had been clipped.
rendernow prints the line one column in and builds each mode line —status, notices, help — for the columns left over, so the inset belongs to
the bar rather than to any one mode and the status line's drop-to-fit logic
stays honest about the pane width. The accent rule still spans edge to edge:
it is a fence, and a gap at its end would read as a break in it.
The monitor panel rows are unchanged and still start at column 0.
Tested:
cargo fmt --all --check,cargo clippy --workspace --all-targets -D warningsandcargo test --workspaceall clean; a newthe_bar_line_is_inset_from_the_left_edgechecks all three bar modes at40/80/200 columns start with a space and never exceed
cols.🤖 Generated with Claude Code
https://claude.ai/code/session_01GDCMtWbUps1fu3JMhyh5y6