Skip to content

ci: create the GitHub release with the App token so dc.yml fires - #1102

Merged
HaoboGu merged 2 commits into
mainfrom
fix/publish-release-token
Aug 29, 2026
Merged

ci: create the GitHub release with the App token so dc.yml fires#1102
HaoboGu merged 2 commits into
mainfrom
fix/publish-release-token

Conversation

@HaoboGu

@HaoboGu HaoboGu commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

The rmk-v0.9.0 GitHub release was created by publish.sh with the workflow's default GITHUB_TOKEN, and events from that token never trigger other workflows — so dc.yml's release: published Discord announcement did not fire (its last run is still v0.8.2).

Mint a token from the release App (same secrets release-pr.yml already uses) and pass it to publish.sh as GH_TOKEN, so gh release create produces an event that triggers dc.yml. Tag pushes still use the checkout credentials and are unaffected.

@HaoboGu
ci: create the GitHub release with the App token so dc.yml fires
be97342 
Events produced by the default GITHUB_TOKEN never trigger other
workflows, so the rmk-v0.9.0 release created by publish.sh did not fire
dc.yml's Discord announcement. Mint the release App's token (the same
one release-pr.yml uses) and hand it to publish.sh as GH_TOKEN.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying rmk-rs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c11546
Status: ✅  Deploy successful!
Preview URL: https://fdf373b2.rmk-4a2.pages.dev
Branch Preview URL: https://fix-publish-release-token.rmk-4a2.pages.dev

View logs

@HaoboGu
ci: clean up comments in publish.yml
7c11546 
Remove comments explaining the use of the release App's token.
@HaoboGu
HaoboGu merged commit 2251a30 into main Aug 29, 2026
62 checks passed
@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown

Size Report

Example main PR Diff .text .data .bss
use_config/nrf52832_ble 391.8 KiB 391.8 KiB +0.00% ⬇️ -4 0 0
use_config/nrf52840_ble 435.5 KiB 435.5 KiB +0.00% ⬇️ -4 0 0
use_config/nrf52840_ble_split (central) 495.9 KiB 495.9 KiB +0.00% ⬆️ +4 0 0
use_config/nrf52840_ble_split (peripheral) 316.9 KiB 316.9 KiB +0.00% 0 0 0
use_config/pi_pico_w_ble 677.9 KiB 677.9 KiB +0.00% ⬇️ -4 0 0
use_config/rp2040 146.7 KiB 146.7 KiB +0.00% 0 0 0
use_config/rp2040_split (central) 161.6 KiB 161.6 KiB +0.00% ⬇️ -4 0 0
use_config/rp2040_split (peripheral) 27.8 KiB 27.8 KiB +0.00% 0 0 0
use_config/stm32f1 63.0 KiB 63.0 KiB +0.00% 0 0 0
use_config/stm32h7 101.0 KiB 101.0 KiB +0.00% 0 0 0
use_rust/nrf52832_ble 380.3 KiB 380.3 KiB +0.00% ⬆️ +4 0 0
use_rust/nrf52840_ble 429.7 KiB 429.7 KiB +0.00% ⬇️ -4 0 0
use_rust/nrf52840_ble_split (central) 494.6 KiB 494.6 KiB +0.00% 0 0 0
use_rust/nrf52840_ble_split (peripheral) 308.7 KiB 308.7 KiB +0.00% 0 0 0
use_rust/pi_pico_w_ble 677.1 KiB 677.1 KiB +0.00% 0 0 0
use_rust/rp2040 146.2 KiB 146.2 KiB +0.00% ⬆️ +4 0 0
use_rust/rp2040_split (central) 160.3 KiB 160.3 KiB +0.00% ⬇️ -4 0 0
use_rust/rp2040_split (peripheral) 28.2 KiB 28.2 KiB +0.00% 0 0 0
use_rust/stm32f1 62.3 KiB 62.3 KiB +0.00% 0 0 0
use_rust/stm32h7 119.5 KiB 119.5 KiB +0.00% 0 0 0
use_config/nrf52832_ble — 391.8 KiB → 391.8 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 358300	   8620	  34272	 401192	  61f28	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 358304	   8620	  34272	 401196	  61f2c	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +62  [ = ]       0    .debug_info
  +0.0%     +35  [ = ]       0    .strtab
  +0.0%     +10  [ = ]       0    .debug_loc
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -9  [ = ]       0    .debug_line
 -45.3%     -34  [ = ]       0    [Unmapped]
  -0.0%    -136  [ = ]       0    .debug_str
  -0.0%     -76  -0.0%      -4    TOTAL
use_config/nrf52840_ble — 435.5 KiB → 435.5 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 393008	   8628	  44312	 445948	  6cdfc	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 393012	   8628	  44312	 445952	  6ce00	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -4  -0.0%      -4    .text
  -0.0%     -10  [ = ]       0    .debug_loc
 -34.2%     -26  [ = ]       0    [Unmapped]
  -0.0%     -40  -0.0%      -4    TOTAL
use_config/nrf52840_ble_split (central) — 495.9 KiB → 495.9 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 448720	   8668	  50408	 507796	  7bf94	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 448716	   8668	  50408	 507792	  7bf90	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +80%     +32  [ = ]       0    [Unmapped]
  +0.0%     +12  [ = ]       0    .strtab
  +0.0%      +4  +0.0%      +4    .text
  -0.0%     -11  [ = ]       0    .debug_line
  -0.0%     -77  [ = ]       0    .debug_info
  -0.0%    -232  [ = ]       0    .debug_str
  -0.0%    -272  +0.0%      +4    TOTAL
use_config/nrf52840_ble_split (peripheral) — 316.9 KiB → 316.9 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 290452	   8508	  25512	 324472	  4f378	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 290452	   8508	  25512	 324472	  4f378	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +32  [ = ]       0    .debug_str
  +0.0%     +16  [ = ]       0    .strtab
  +0.0%      +1  [ = ]       0    .debug_line
  +1.5%      +1  [ = ]       0    [Unmapped]
  -0.0%      -2  [ = ]       0    .debug_info
  +0.0%     +48  [ = ]       0    TOTAL
use_config/pi_pico_w_ble — 677.9 KiB → 677.9 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 639820	      0	  54336	 694156	  a978c	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 639824	      0	  54336	 694160	  a9790	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +191  [ = ]       0    .debug_info
  +0.0%     +20  [ = ]       0    .debug_line
  +0.0%     +10  [ = ]       0    .debug_loc
  +0.0%      +4  +0.0%      +4    .text
  +6.2%      +4  [ = ]       0    [Unmapped]
  -0.0%      -8  -0.0%      -8    .rodata
  -0.0%     -25  [ = ]       0    .strtab
  -0.0%     -60  [ = ]       0    .debug_str
  +0.0%    +136  -0.0%      -4    TOTAL
use_config/rp2040 — 146.7 KiB → 146.7 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 136052	      0	  14196	 150248	  24ae8	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 136052	      0	  14196	 150248	  24ae8	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +173  [ = ]       0    .debug_str
  +0.1%    +111  [ = ]       0    .debug_line
  +0.0%     +15  [ = ]       0    .debug_info
  +0.0%      +9  [ = ]       0    .strtab
  +0.0%    +308  [ = ]       0    TOTAL
use_config/rp2040_split (central) — 161.6 KiB → 161.6 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 150216	      0	  15276	 165492	  28674	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 150220	      0	  15276	 165496	  28678	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -5  [ = ]       0    .strtab
 -43.5%     -30  [ = ]       0    [Unmapped]
  -0.0%     -37  [ = ]       0    .debug_info
  -0.0%    -104  [ = ]       0    .debug_str
  -0.1%    -124  [ = ]       0    .debug_line
  -0.0%    -304  -0.0%      -4    TOTAL
use_config/rp2040_split (peripheral) — 27.8 KiB → 27.8 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25520	     60	   2908	  28488	   6f48	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25520	     60	   2908	  28488	   6f48	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +2  [ = ]       0    .debug_str
  +0.0%      +1  [ = ]       0    .strtab
  -4.3%      -3  [ = ]       0    [Unmapped]
  [ = ]       0  [ = ]       0    TOTAL
use_config/stm32f1 — 63.0 KiB → 63.0 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  57856	     28	   6660	  64544	   fc20	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  57856	     28	   6660	  64544	   fc20	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL
use_config/stm32h7 — 101.0 KiB → 101.0 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  94788	    264	   8412	 103464	  19428	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  94788	    264	   8412	 103464	  19428	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%     -36  [ = ]       0    .debug_info
  -0.0%    -100  [ = ]       0    .debug_str
  -0.1%    -124  [ = ]       0    .debug_line
  -0.0%    -260  [ = ]       0    TOTAL
use_rust/nrf52832_ble — 380.3 KiB → 380.3 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 346608	   8620	  34216	 389444	  5f144	rmk-nrf52832

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 346604	   8620	  34216	 389440	  5f140	rmk-nrf52832

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +134  [ = ]       0    .debug_info
  +0.0%     +10  [ = ]       0    .debug_loc
  +0.0%      +5  [ = ]       0    .strtab
  +0.0%      +4  +0.0%      +4    .text
  +0.0%      +1  [ = ]       0    .debug_line
  -3.1%      -2  [ = ]       0    [Unmapped]
  -0.0%     -96  [ = ]       0    .debug_str
  +0.0%     +56  +0.0%      +4    TOTAL
use_rust/nrf52840_ble — 429.7 KiB → 429.7 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 389800	   8628	  41544	 439972	  6b6a4	rmk-nrf52840

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 389804	   8628	  41544	 439976	  6b6a8	rmk-nrf52840

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +10  [ = ]       0    .debug_loc
   +20%     +10  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  +0.0%     +16  -0.0%      -4    TOTAL
use_rust/nrf52840_ble_split (central) — 494.6 KiB → 494.6 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 445976	   8668	  51824	 506468	  7ba64	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 445976	   8668	  51824	 506468	  7ba64	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +12  [ = ]       0    .strtab
  -0.0%      -5  [ = ]       0    .debug_line
  -9.4%      -6  [ = ]       0    [Unmapped]
  -0.0%     -12  [ = ]       0    .debug_loc
  -0.0%     -77  [ = ]       0    .debug_info
  -0.0%    -232  [ = ]       0    .debug_str
  -0.0%    -320  [ = ]       0    TOTAL
use_rust/nrf52840_ble_split (peripheral) — 308.7 KiB → 308.7 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 282564	   8508	  25056	 316128	  4d2e0	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 282564	   8508	  25056	 316128	  4d2e0	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +32  [ = ]       0    .debug_str
  +0.0%     +16  [ = ]       0    .strtab
  +0.0%      +1  [ = ]       0    .debug_line
  -0.0%      -2  [ = ]       0    .debug_info
  -5.8%      -3  [ = ]       0    [Unmapped]
  -0.0%     -12  [ = ]       0    .debug_loc
  +0.0%     +32  [ = ]       0    TOTAL
use_rust/pi_pico_w_ble — 677.1 KiB → 677.1 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 639360	      0	  54016	 693376	  a9480	rmk-pi-pico-w

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 639360	      0	  54016	 693376	  a9480	rmk-pi-pico-w

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +76  [ = ]       0    .debug_info
  -0.0%      -8  [ = ]       0    .strtab
  -0.0%     -21  [ = ]       0    .debug_str
  -0.4%     -39  [ = ]       0    .debug_abbrev
  -0.0%     -72  [ = ]       0    .debug_line
  -0.0%     -64  [ = ]       0    TOTAL
use_rust/rp2040 — 146.2 KiB → 146.2 KiB (+0.00% ⬆️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 135708	      0	  14028	 149736	  248e8	rmk-rp2040

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 135704	      0	  14028	 149732	  248e4	rmk-rp2040

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +72  [ = ]       0    .debug_str
  +0.0%      +8  [ = ]       0    .strtab
  +0.0%      +4  +0.0%      +4    .text
 -10.5%      -6  [ = ]       0    [Unmapped]
  -0.0%     -22  [ = ]       0    .debug_info
  -0.0%     -60  [ = ]       0    .debug_line
  -0.0%      -4  +0.0%      +4    TOTAL
use_rust/rp2040_split (central) — 160.3 KiB → 160.3 KiB (+0.00% ⬇️)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 149164	      0	  15020	 164184	  28158	central

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 149168	      0	  15020	 164188	  2815c	central

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +4.7%      +3  [ = ]       0    [Unmapped]
  -0.0%      -4  -0.0%      -4    .text
  -0.0%      -5  [ = ]       0    .strtab
  -0.0%     -37  [ = ]       0    .debug_info
  -0.0%    -105  [ = ]       0    .debug_str
  -0.1%    -124  [ = ]       0    .debug_line
  -0.0%    -272  -0.0%      -4    TOTAL
use_rust/rp2040_split (peripheral) — 28.2 KiB → 28.2 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  25632	     60	   3172	  28864	   70c0	peripheral

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  25632	     60	   3172	  28864	   70c0	peripheral

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +753  [ = ]       0    .debug_str
  +0.2%     +41  [ = ]       0    .strtab
  +4.0%      +2  [ = ]       0    [Unmapped]
  +0.1%    +796  [ = ]       0    TOTAL
use_rust/stm32f1 — 62.3 KiB → 62.3 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
  57236	     28	   6580	  63844	   f964	rmk-stm32f1

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
  57236	     28	   6580	  63844	   f964	rmk-stm32f1

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +201  [ = ]       0    .debug_str
  +0.0%     +14  [ = ]       0    .strtab
  -4.5%      -3  [ = ]       0    [Unmapped]
  +0.0%    +212  [ = ]       0    TOTAL
use_rust/stm32h7 — 119.5 KiB → 119.5 KiB (+0.00%)

cargo size (PR):

   text	   data	    bss	    dec	    hex	filename
 107756	    320	  14316	 122392	  1de18	rmk-stm32h7

cargo size (main):

   text	   data	    bss	    dec	    hex	filename
 107756	    320	  14316	 122392	  1de18	rmk-stm32h7

Bloaty diff (PR vs main):

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%      -1  [ = ]       0    .strtab
  -7.5%      -3  [ = ]       0    [Unmapped]
  -0.0%     -10  [ = ]       0    .debug_loc
  -0.0%     -37  [ = ]       0    .debug_info
  -0.0%    -101  [ = ]       0    .debug_str
  -0.1%    -124  [ = ]       0    .debug_line
  -0.0%    -276  [ = ]       0    TOTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HaoboGu