Conversation
… open streams with_graceful_shutdown waits for in-flight requests to finish. Long-lived streams (process log follow SSE, ACP event feeds) never complete on their own, so Ctrl+C left the server running until kill -9. Listen for SIGTERM alongside SIGINT (daemon stop already sends it, and it previously bypassed cleanup entirely), then bound the drain: a second signal or a 3s timeout exits the process. Fixes #6
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6 - Ctrl+C did not shut down the server when long-lived streams were open.
axum::serve(...).with_graceful_shutdown(...)waits for in-flight requests to finish. SSE streams (/v1/processes/{id}/logs?follow=true,/v1/acp/{id}, opencode compat event feeds) never complete on their own, so the drain blocked forever and the process neededkill -9.sandbox-agent daemon stopalready sends it, and it previously fell through to the default action - an instant terminate that skippedshutdown_serverscleanup (opencode sidecar, ACP runtimes) entirely.Verification (live, darwin/arm64)
Reproduced on unpatched build: server +
sleep 300process + openlogs?follow=trueSSE → SIGINT → still running at 10s; exits only once the SSE connection closed.Patched build:
cargo test -p sandbox-agent --lib: 22 passed.cargo fmt --checkclean,cargo clippyclean (one pre-existing warning unrelated to this change).