fix(acp-http-client): isolate detached POST failures - #306
Open
RGHenderson wants to merge 1 commit into
Open
RGHenderson wants to merge 1 commit into
RGHenderson wants to merge 1 commit into
Conversation
Reject only the matching JSON-RPC request when a detached request POST fails so the shared SSE transport remains usable.
RGHenderson
force-pushed
the
fix/acp-request-scoped-post-errors
branch
from
July 20, 2026 21:44
2f5d1fa to
4cd4655
Compare
RGHenderson
marked this pull request as ready for review
July 21, 2026 08:45
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
postMessageruns detached so long-running requests do not block client replies. A network failure in one detached POST currently errors the shared readable stream, terminating an otherwise healthy SSE connection and every pending or subsequent request.Rationale
Requests already have JSON-RPC IDs, so a POST failure can be represented as an error response for that request. Notifications have no response to reject and retain the existing transport-fatal behavior.
The broader proposal to return
202 Acceptedfor long-running requests and deliver completion over SSE is tracked separately in #305.Test plan
pnpm --filter acp-http-client typechecksandbox-agentand runpnpm --filter acp-http-client testFixes #307