Merged
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A reindexer test was asserting the wrong contract for `Reindexer.TestSignals.Reindexed`. The test waited twice on the signal as though it fired once per index or once per startup cycle, but the reindexer sends it once after a run has finished processing all configured indexes. In the failing run, the client logged a complete reindex pass, including `Initiated reindex` for every default index, and then the test timed out waiting for another signal that would never arrive: https://github.com/riverqueue/river/actions/runs/24406465152 Configure the client with a single reindex target and wait for one `Reindexed` signal. That keeps this test focused on what it actually owns, which is proving that the client wires up the reindexer and lets a run complete through the full stack. The more detailed scheduling and multi-index behavior stay covered by the dedicated reindexer tests, so this client-level assertion no longer depends on the size of the default index list or on how long a full reindex pass happens to take on CI.
bgentry
force-pushed
the
bg/stabilize-reindexer-test
branch
from
2bf6c51 to
cf38569
Compare
brandur
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reindexer test was asserting the wrong contract for
Reindexer.TestSignals.Reindexed. The test waited twice on the signal as though it fired once per index or once per startup cycle, but the reindexer sends it once after a run has finished processing all configured indexes.In the failing run, the client logged a complete reindex pass, including
Initiated reindexfor every default index, and then the test timed out waiting for another signal that would never arrive:https://github.com/riverqueue/river/actions/runs/24406465152
Configure the client with a single reindex target and wait for one
Reindexedsignal. That keeps this test focused on what it actually owns, which is proving that the client wires up the reindexer and lets a run complete through the full stack.The more detailed scheduling and multi-index behavior stay covered by the dedicated reindexer tests, so this client-level assertion no longer depends on the size of the default index list or on how long a full reindex pass happens to take on CI.