feat(notifications): implement WebSocket reconnection for notification system (#405)#680
Merged
RUKAYAT-CODER merged 1 commit intoJun 24, 2026
Conversation
…n system Extract a dedicated NotificationSocketService with exponential backoff, outbound message queuing, and browser lifecycle recovery hooks. Expose connection state via NotificationProvider and add unit/integration tests for issue rinafcode#405.
|
@GEEKYFOCUS Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #405
This PR implements production-ready WebSocket reconnection for the real-time Notification System. The socket logic is extracted from
NotificationProviderinto a dedicated, testableNotificationSocketServicemodule.Key changes
New
NotificationSocketService(src/lib/notifications/socket.ts)notification_read/notification_clearactions are not lost while disconnectedonline,visibilitychange) for faster recovery when connectivity returnsNotificationProviderrefactor@/lib/notifications/socketconnectionStatevia context so UI can reflect connection health (e.g. reconnecting indicator)Test coverage
Documentation
docs/NOTIFICATION_SYSTEM_REFACTORING.mdMotivation
The previous inline WebSocket implementation had basic reconnect logic but lacked:
This change improves reliability in production environments where network interruptions are common.
Acceptance criteria
pnpm test src/lib/notifications/__tests__/socket.test.ts src/providers/__tests__/Notificationprovider.test.tsx)connectionState)wsUrl)Test plan
pnpm test src/lib/notifications/__tests__/socket.test.tspnpm test src/providers/__tests__/Notificationprovider.test.tsx<NotificationProvider>connectionState.statustransitions:connecting→connected→reconnecting→connectedNotes for reviewers
connectionStateis a new field on the provider context; existing consumers are unaffected unless they opt in.maxReconnectAttemptsis0(unlimited), matching resilient production behavior. Callers can cap attempts viaNotificationSocketOptionsif needed.