Conversation
duffert
reviewed
Jul 17, 2018
duffert
left a comment
There was a problem hiding this comment.
Nice try, but this will not work. Even though you set the correct HiddenServiceVersion, the internal structure of Ricochet needs to be updated in order to support HiddenService version 3. We need to be able to load (and store) version 3 private and public keys, as well as to be able to handle the different cryptographic algorithems associated with v2 and v3 HiddenService identifiers.
Author
|
Thanks for the explanation, I expected something like that :) |
|
V3 support was recently added to stem so this might be possible now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
according to
config/tor/statethis commit has been tested withTorVersion Tor 0.3.3.9 (git-ca1a436fa8e53a32)
In the UI the dialog to add contacts still shows a short id (ricochet:dkska2iuk3byot7g) and I expected it be longer, so maybe this change was not enough to create a v3 onion service yet.
I am waiting here for interested people to test if connections work (ricochet is not always on).