Ricochet's icon in tray by kolodziej · Pull Request #260 · ricochet-im/ricochet

kolodziej · 2015-09-06T17:48:45Z

Features:

Icon changes when user has unread messages.
Left click on tray icon shows and hides main window
Right click gives context menu with four options:
- preferences
- add contact
- copy my id [to clipboard]
- quit
User can activate option which will change behavior of close ('X') button to make it hides window, not closes application.

This PR is related to issue #247

Add to preferences option which changes behaviour of Close button from closing application to hiding MainWindow.

If MainWindow is hidden, slot for contact signal in main.qml changes visibility of MainWindow first.

special · 2015-09-17T21:38:32Z

trayIcon is leaked on destruction

special · 2015-09-17T21:54:15Z

I think the tray icon should only be visible when close-to-tray is enabled. We could also make a separate option, but I like that less. What do you think?

Looking good - I think this can be ready to merge after the above comments.

1. Destruction of TrayIcon object in MainWindow's destructor 2. Forward declaration of TrayIcon in src/ui/MainWindow.h 3. QIcon objects for TrayIcon's constructor as const references 4. New names for TrayIcon's signals, removes unnecessary slots and connects signals from TrayIcon's context menu to another signals 5. Fixes braces style: brace in the same line as if/else in QML 6. Title case in TrayIcon's context menu

kolodziej · 2015-09-17T23:33:17Z

Ok. I think everything's done.

rburchell · 2015-09-18T10:35:37Z

these are unused?

1. Removes unused TrayIcon::setStdIcon and TrayIcon::setUnreadIcon 2. Removes code formatting issues

kolodziej · 2015-09-18T11:59:50Z

I hope now it's ok :)

rburchell · 2015-09-18T12:05:37Z

thanks :)

qsodev · 2015-09-21T21:17:44Z

looks good :)

kolodziej · 2015-09-21T21:37:20Z

It's about time to merge :)

puzanov · 2015-12-17T13:30:57Z

Is it in master?

kolodziej · 2015-12-23T23:40:51Z

Not yet, but it's ready since end of September.

special · 2016-01-02T15:17:46Z

Toggling the window when the tray icon is clicked doesn't behave well. On some platforms, the window is hiding every time you click to open the context menu on the tray. How do most messaging-type applications behave here?

It's less important, but the unread icon is too subtle, also. Maybe recoloring the entire icon to orange would be better. We could merge without that.

We should disable tray icons entirely on OS X. Adding a #ifndef Q_OS_MAC in the right place would do. I can do this after merge if needed.

qsodev · 2016-01-03T10:26:39Z

For example Pidgin and Psi open and close the main window on single click. Right click opens the context menu.

ZimTester · 2016-02-21T17:55:53Z

Single click is the best Windows practice, agree

kolodziej · 2016-02-25T00:31:10Z

The only think that could be done is new 'unread icon'. After merging this branch into master we can make an issue. Maybe we have anybody who is better in graphics than me ;)

qsodev · 2016-02-25T16:08:12Z

what about simply flashing the already existing tray icon when there are unread messages?

kolodziej · 2016-02-25T22:47:27Z

I think it could be done. What do you think, should it be default behaviour or just an option?

ZimTester · 2016-02-27T09:30:48Z

I still think the best way is using a special icon for unread incoming messages, and here is why:
Flashing should be switchable on/off by option, because not everybody likes it. But it's ok to make it on by default. But when it's off we should see that we have unread messages, that's why we need a special icon. (Also if we have it then we should see the same special icon when flashing is on too).
Maybe you can choose something from any free icon packs? Hm...
That's just my humble opinion after using another messengers.

kolodziej · 2016-02-27T20:17:36Z

We have special icon with dot. It's not very effective and I wanted to change it. I didn't know if it is enough to set new, more different icon or make it flash.

kolodziej · 2016-03-05T16:06:33Z

I've changed unread icon and add blinking when we have unread messages.

We need someone who will make this feature available on os x.

Kacper Kołodziej added 9 commits September 6, 2015 13:51

tray-icon: Add Ricochet icon with dot

c65963c

tray-icon: Implementation of TrayIcon class

2c710ce

tray-icon: Add TrayIcon instance to MainWindow

c87cbef

tray-icon: support TrayIcon's toggleWindow signal

1a433cb

tray-icon: Add context menu on right click on icon

57d169b

tray-icon: Add notifying icon about unread message

1fa46f6

tray-icon: Alternative behaviour for Close button

cafd4e3

Add to preferences option which changes behaviour of Close button from closing application to hiding MainWindow.

tray-icon: Modified behaviour when icon is clicked

c07de7c

tray-icon: fix 'Add Contact' option in icon's menu

82a7983

If MainWindow is hidden, slot for contact signal in main.qml changes visibility of MainWindow first.

special reviewed Sep 17, 2015
View reviewed changes

Comment thread src/ui/MainWindow.cpp Outdated

special Sep 17, 2015

Copy link
Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trayIcon is leaked on destruction

special mentioned this pull request Sep 17, 2015

added tray icon support #262

Closed

rburchell reviewed Sep 18, 2015
View reviewed changes

Comment thread src/ui/TrayIcon.h Outdated

rburchell Sep 18, 2015

Copy link
Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are unused?

tray-icon: Fixes problems mentioned by rburchell

1789f0c

1. Removes unused TrayIcon::setStdIcon and TrayIcon::setUnreadIcon 2. Removes code formatting issues

kolodziej mentioned this pull request Dec 23, 2015

Minimize to systray? #305

Closed

turns tray icon off on OS X

0e9ec66

Merge commit 'master' into 247-tray-icon

69d34e9

Kacper Kołodziej added 3 commits March 5, 2016 16:58

tray-icon: blinking icon when there are unread messages

d26c69e

tray-icon: change unread icon

15f8fb6

tray-icon: information about author of unread icon

592cfcf

ghost mentioned this pull request Nov 8, 2016

Minimizing to tray, file transfer, automatic updates and bridge support #479

Closed

Uh oh!

Conversation

kolodziej commented Sep 6, 2015

Uh oh!

special Sep 17, 2015

Choose a reason for hiding this comment

Uh oh!

special commented Sep 17, 2015

Uh oh!

kolodziej commented Sep 17, 2015

Uh oh!

rburchell Sep 18, 2015

Choose a reason for hiding this comment

Uh oh!

kolodziej commented Sep 18, 2015

Uh oh!

rburchell commented Sep 18, 2015

Uh oh!

qsodev commented Sep 21, 2015

Uh oh!

kolodziej commented Sep 21, 2015

Uh oh!

puzanov commented Dec 17, 2015

Uh oh!

kolodziej commented Dec 23, 2015

Uh oh!

special commented Jan 2, 2016

Uh oh!

qsodev commented Jan 3, 2016

Uh oh!

ZimTester commented Feb 21, 2016

Uh oh!

kolodziej commented Feb 25, 2016

Uh oh!

qsodev commented Feb 25, 2016

Uh oh!

kolodziej commented Feb 25, 2016

Uh oh!

ZimTester commented Feb 27, 2016

Uh oh!

kolodziej commented Feb 27, 2016

Uh oh!

kolodziej commented Mar 5, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kolodziej commented Mar 5, 2016 •

edited

Loading