Repository navigation
LG webOS TV transport - #319
Merged
Merged
Conversation
…tion A webostv transport, set up automatically with the LG webOS TV integration. Each TV's media_player entity is the target, mapped to the TV's legacy notify action through its config entry, so TVs can be reached directly or by area, floor, label or device. TVs that are off or unavailable are skipped, only the message is shown (the title only when there's no message), and data.icon is passed through. Delivery selection now resolves area_id/floor_id/label_id selectors when checking whether a delivery's target category is present, so an area target selects the transport that owns what's in it - webostv for a TV, alexa_devices for an echo - rather than only the generic notify entity catch-all. Closes #313 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A transport that sends nothing can set envelope.skip_reason, such as NO_TARGET for Kodi, Discord or a webOS TV that's off, but the engine always recorded UNKNOWN. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313.
LG webOS TV transport
webostvdelivery is set up automatically with the LG webOS TV integration, with no YAML.media_playerentity is the target. The TV's legacy notify action, such asnotify.living_room_tv, is found through its config entry, so a TV can be reached directly or by area, floor, label or device.data.iconis passed through.Area, floor and label targets in delivery selection
Delivery selection now resolves
area_id/floor_id/label_idwhen checking whether a delivery's target type is present. An area target therefore selects the transport that owns what's in it:webostvfor a TV, andalexa_devicesfor an Echo. Before, only the catch-allnotify_entitydelivery picked up area targets. Two existing integration tests change only in the order of the same calls.Skip reason fix
A reason a transport gives for sending nothing, such as
NO_TARGET, is now kept instead of always being recorded asUNKNOWN. This also fixes Kodi and Discord.Testing
Houseintegration tests, with each TV's area on its device as in a real install. All 2860 tests pass, with 97% coverage.Docs
🤖 Generated with Claude Code