Skip to content

[WIP] Consolidate some of the examples in one screen - #280

Open
jeremyscatigna wants to merge 3 commits into
revery-ui:masterfrom
jeremyscatigna:jeremyscatigna/feature/InputMethodExamples
Open

[WIP] Consolidate some of the examples in one screen#280
jeremyscatigna wants to merge 3 commits into
revery-ui:masterfrom
jeremyscatigna:jeremyscatigna/feature/InputMethodExamples

Conversation

@jeremyscatigna

Copy link
Copy Markdown

first part of the implementation still WIP, trying to implement both button and input examples

@OhadRau

OhadRau commented Jan 31, 2019

Copy link
Copy Markdown
Collaborator

@jeremyscatigna Looks like the CI never triggered. Maybe try merging in master and pushing again? Usually another push will get it to work.

@bryphe

bryphe commented Feb 8, 2019

Copy link
Copy Markdown
Member

Just tried this out and its looking great, @jeremyscatigna ! Thank you for your work on this (and sorry I was so delayed in reviewing it).

There's only tweak - I wonder if we could center the example vertically / horizontally? Would help for our web playground!

Was there anything else that was top of mind for you?

Let me know if you need help with the merge or wrapping this up - having these elements consolidated is a big improvement! 👍

@jeremyscatigna

Copy link
Copy Markdown
Author

Thanks @bryphe ! Almost finished need to clean the layout a bit and all that fill in properly, will center the example and let you know when good.

Would love help to merge when everythings good 💪

@albertorestifo

Copy link
Copy Markdown

Related to #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants