Deps/remove refmterr rely - #37
Open
Et7f3 wants to merge 7 commits into
Open
Conversation
Et7f3
force-pushed
the
deps/remove-refmterr-rely
branch
from
September 20, 2020 23:23
efa53a6 to
c8d8717
Compare
Et7f3
force-pushed
the
deps/remove-refmterr-rely
branch
from
September 20, 2020 23:40
3fb769e to
ed31f11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hy @bryphe in response to revery-ui/revery#844
We pull rely with rench (that is used by revery). With this PR rely is no longer pulled from revery consumer.
Also the diff with hello-reason setup is we don't use the dsl
#{self.name}but we useRenchthis change is a breaking change so I haven't done.I have checked lower bound of OCaml until 4.06 (no project use lower so it is fine).
While updating this PR I have seen we pull useless deps that aren't mentionned like lambda-term (only present in lockfile) or lwt (I presume because of threads.posix) I have pruned them. It will help for revery-ui/revery#890