Skip to content

EPMRPP-115237 || Move encryption logic to service-api#6

Merged
Evelina02 merged 3 commits into
developfrom
EPMRPP-115237-encrypt-sensitive
Jun 18, 2026
Merged

EPMRPP-115237 || Move encryption logic to service-api#6
Evelina02 merged 3 commits into
developfrom
EPMRPP-115237-encrypt-sensitive

Conversation

@Evelina02

@Evelina02 Evelina02 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated service API dependency to the latest compatible version
    • Updated plugin display name from "GitHub Auth Plugin" to "GitHub Auth"
    • Enhanced parameter encryption handling for authentication configuration

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@grabsefx, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 8 minutes and 54 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 978cfe8e-a31d-4b2b-885c-012816f10db4

📥 Commits

Reviewing files that changed from the base of the PR and between cc576b7 and af9a81a.

📒 Files selected for processing (3)
  • build.gradle
  • src/main/java/com/epam/reportportal/extension/github/GitHubExtension.java
  • src/main/java/com/epam/reportportal/extension/github/oauth/GitHubOAuth2UserService.java

Walkthrough

The PR migrates the encryption abstraction from BasicTextEncryptor to IntegrationParamsEncryptor in GitHubExtension and GitHubIntegrationStrategy, updates the plugin display name from "GitHub OAuth Plugin" / "GitHub Auth Plugin" to "GitHub OAuth" / "GitHub Auth", and bumps the service-api dependency version from b6fe35f3df to 771a360.

Changes

GitHub Auth Plugin – Encryptor migration and plugin rename

Layer / File(s) Summary
BasicTextEncryptor → IntegrationParamsEncryptor migration
src/main/java/.../service/GitHubIntegrationStrategy.java, src/main/java/.../GitHubExtension.java
GitHubIntegrationStrategy constructor updated to accept IntegrationParamsEncryptor paramsEncryptor and forward it to the AuthIntegrationStrategy superclass. GitHubExtension field type changed from BasicTextEncryptor to IntegrationParamsEncryptor, and the construction call updated accordingly.
Plugin name rename and service-api bump
src/main/java/.../GitHubExtension.java, gradle.properties, build.gradle
PLUGIN_NAME constant changed from "GitHub OAuth Plugin" to "GitHub OAuth"; pluginName shortened to "GitHub Auth"; service-api implementation and annotationProcessor dependencies bumped from b6fe35f3df to 771a360.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • pbortnik

Poem

🐇 Hop hop, the encryptor swaps,
BasicText fades, IntegrationParams maps!
The plugin name trims a word or two,
And service-api gets a version brand new.
A tidy burrow, clean and bright —
This rabbit thinks the diff looks right! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: moving encryption logic to the service-api library, which is reflected in the dependency update and the replacement of BasicTextEncryptor with IntegrationParamsEncryptor.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch EPMRPP-115237-encrypt-sensitive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@build.gradle`:
- Around line 38-39: The service-api dependency for both implementation and
annotationProcessor declarations is pinned to a JitPack commit hash (771a360)
instead of a stable semantic version from ReportPortal's official releases.
Replace the commit hash with a stable release version number (such as 5.14.0 or
later) in both the implementation and annotationProcessor entries for
com.github.reportportal:service-api to ensure API stability and proper support
for the IntegrationParamsEncryptor class that is actively used throughout the
codebase.

In `@src/main/java/com/epam/reportportal/extension/github/GitHubExtension.java`:
- Line 78: The PLUGIN_NAME constant in the GitHubExtension class is set to
"GitHub OAuth" while the pluginName property in gradle.properties is set to
"GitHub Auth", causing the plugin to have two different public identities. To
fix this, align the PLUGIN_NAME constant value in GitHubExtension to match the
pluginName value defined in gradle.properties, or vice versa, ensuring both
locations reference the same display name for the plugin.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 083da2d2-07c6-4008-aefb-00dada1b7a13

📥 Commits

Reviewing files that changed from the base of the PR and between 11fea2e and cc576b7.

📒 Files selected for processing (4)
  • build.gradle
  • gradle.properties
  • src/main/java/com/epam/reportportal/extension/github/GitHubExtension.java
  • src/main/java/com/epam/reportportal/extension/github/service/GitHubIntegrationStrategy.java

Comment thread src/main/java/com/epam/reportportal/extension/github/GitHubExtension.java Outdated
@reportportal reportportal deleted a comment from coderabbitai Bot Jun 18, 2026
…strictions method and remove unused constants
@Evelina02 Evelina02 merged commit 83e370a into develop Jun 18, 2026
3 checks passed
@Evelina02 Evelina02 deleted the EPMRPP-115237-encrypt-sensitive branch June 18, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants