Repository navigation
perf: spindel 0.1.102 and cheaper seeded streams (~2x SMC) - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-site stream seeding was ~21% of SMC CPU. canonical walks only collections (no postwalk on scalars), the UUID's words come from its bits instead of hex parsing (JVM), and next-u32! no longer recomputes the step it just applied. Generator states are bit-identical: a new test checks words and 100 draws against the previous computation for scalar, vector, map, list, set and map-entry seeds. ~1.05× on the SMC benchmark on top of spindel #108; identical log-marginals.