Repository navigation
ci: run the qsys-mac-installer smoke test on the macOS leg - #11
Merged
Merged
Conversation
The last remaining item from the 2026-07-09 audit: scripts/test.sh existed but
no workflow invoked it, so the installer's guarantees went unchecked in CI.
Adds a macOS-only step to the existing job that runs test.sh with
QSYS_SKIP_XCODE=1 — shell-syntax across the 9 installer scripts, WINEDLLOVERRIDES
launch-path parity (dev / generated .app / installed GUI), the MSI
path-containment fixtures, and the Wine process-cleanup harness (which stubs
wineserver, so no real Wine is required). Guarded by
`if: matrix.os == 'macos-latest'` so the two Linux legs skip it.
The xcodebuild half is deliberately skipped: the Installer target copies
Resources/{bin,cache}, which are gitignored and only populated by bundle-deps.sh
(it downloads the Wine + .NET bundle). In a clean checkout those dirs are absent,
so `xcodegen generate` fails spec validation before any build runs — that Swift
compile belongs to packaging, not a per-PR gate.
Verified against a clean `git worktree` (tracked files only, mirroring the CI
runner): the full script fails at xcodegen as described; QSYS_SKIP_XCODE=1 exits
0 with "all checks passed". ci.yml parses and the step is attached to the macOS
leg only.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last remaining item from the 2026-07-09 audit:
scripts/test.shexisted but no workflow invoked it, so the installer's guarantees went unchecked in CI.What this adds
A macOS-only step on the existing
testjob that runspackages/qsys-mac-installer/scripts/test.shwithQSYS_SKIP_XCODE=1. Guarded byif: matrix.os == 'macos-latest', so the two Linux legs skip it.What CI now enforces on every PR:
WINEDLLOVERRIDESlaunch-path parity (dev / generated.app/ installed GUI — the drift guard)wineserver, so no real Wine is needed — CI-safe)What it deliberately doesn't cover
The
xcodebuildcompile. The Installer target copiesResources/{bin,cache}, which are gitignored and only materialized bybundle-deps.sh(it downloads the Wine + .NET bundle). In a clean checkout those dirs are absent, soxcodegen generatefails spec validation ("missing source directory") before any build runs — that Swift compile belongs to packaging, not a per-PR gate.If we want that coverage later, the clean way is a separate, path-filtered job (only when
packages/qsys-mac-installer/**changes) that runsbundle-deps.shthen the fulltest.sh— heavier, so it shouldn't gate every PR.Verification
Verified against a clean
git worktree(tracked files only, mirroring the CI runner): the full script fails atxcodegenas described;QSYS_SKIP_XCODE=1exits 0 with "all checks passed".ci.ymlparses and the step is attached to the macOS leg only.🤖 Generated with Claude Code