Repository navigation
Lychee skips the changelog compare and tag links - #20
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lychee no longer fails every release PR. It skips the CHANGELOG footer's compare and release tag links.
Why
#18 made lychee check the root
*.mdpages, CHANGELOG.md included. In a release PR the footer's[Unreleased]compare link and the new version's tag link point at a tag that is only pushed after the PR merges. On #19, docs CI failed with exactly those two:[404] .../compare/v0.2.5...HEADand[404] .../releases/tag/v0.2.5.What changed
lychee.tomlexcludes^https://github\.com/rennf93/murmur/compare/and^https://github\.com/rennf93/murmur/releases/tag/, with a comment saying why.Issue
No issue. Found on #19.
How it was verified
git grepfinds those URL prefixes only in CHANGELOG.md:140-147, so nothing else is skipped. The[0.1.0]commit link, the repo root,/issues,/pull,/releases,/bloband/securitylinks stay checked (lychee --dump).v9.9.9: master's config exits 2 with[404] .../compare/v9.9.9...HEAD; the new config reports0 Errors, 8 Excluded.90 OK, 0 Errors, 9 Excluded.npm run coverage:Tests 508 passed (508), 100 percent. typos exit 0, markdownlint 0 issues.releases/tag/v0.2.5404 instead.Behavior changes
A typo in a footer version link is no longer caught, for the already published tags too.