Repository navigation
Trim over-engineering across server, web, and root tooling - #9
Merged
Merged
Conversation
Share the job progress loop, subprocess runner and file download helpers; return drizzle rows directly instead of field-by-field mappers; drop dead drizzle index metadata, model_status, autoScanInterval API field, IN_DOCKER and config aliases; derive enums, editable settings keys and config keys from single sources.
One MediaBrowser for Explore/Library/Board pages, one native <dialog> Modal for all dialogs, a global mutation error toast, shared settings/event-source hooks and a Segmented control. Drop Confetti, dead API methods and props. Render release notes at build time so marked leaves the bundle.
Drop unused better-sqlite3 and form-data, tracked junk (features.txt, .idea), stale .dockerignore entries and script banners; fold the nginx media location into /api/ and regenerate bun.lock.
Report tag and transcode progress after every item again, only accept a downloader library lookup for the current path, and handle Chromium closing a modal on a repeated Escape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schema.tsindex/enum declarations in favor of shared enums (@sakuya/shared) and the raw DDL already indb/index.ts; de-duplicated the phash band migrations/columns/indexes into aBANDSlooplib/config.ts: droppedIN_DOCKER, inlined one-off exports (PORT,HOST,AUTH_*), readAPP_VERSIONvia a staticpackage.jsonimport instead of a try/catch file readlib/auth.tswithBun.CookieMaplib/download.ts(temp-file download),lib/run.ts(child process runner with bounded stderr),lib/http.tscursor encode/decode,lib/rowToMedia.tscountMedia,lib/mediaByIds.tsmediaIdsWherediscover.ts,media.ts,tags.ts, and the downloader/transcoder/scanner services to remove duplicated query/process-spawning codeuseAuthto a plain hook, new sharedModal/Segmentedprimitives, trimmedSelectionBar,BulkRenameDialog,BulkTagDialog, settings tabs); removed the unusedConfetticomponent.idea/.gitignore,features.txt, unused root scripts/config entries, and unused dependencies (e.g.typescriptdevDependency,ffprobe-statictypes already covered); updated CI to runbun run testand switched.impeccable/config.jsonignore rules.dockerignoreno longer excludes nonexistenttray/.junie/run-hoyovault-upload.shpathsTesting
bun test/bun run testbun run build(web + server)