Skip to content

Metal: release held drawables when the swap chain resizes #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yorgunkral31 wants to merge 1 commit into from
Closed

Metal: release held drawables when the swap chain resizes #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions plume_metal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1993,6 +1993,19 @@ namespace plume {

bool MetalSwapChain::resize() {
MetalAutoreleasePool releasePool;

// Drop any drawables still held from the previous swap chain generation.
// On iOS the layer's drawables are invalidated when the app is suspended,
// and holding or presenting them across a resume is undefined behavior.
// Callers idle the GPU before resizing, so the references are safe to release.
for (uint32_t i = 0; i < MAX_DRAWABLES; i++) {
MetalDrawable &drawable = drawables[i];
if (drawable.mtl != nullptr) {
drawable.mtl->release();
drawable.mtl = nullptr;
}
}

getWindowSize(width, height);

if (width == 0 || height == 0) {
Expand Down