Skip to content

fix: define error timestamps as ISO datetimes - #200

Open
luwqz1 wants to merge 1 commit into
remnawave:devfrom
luwqz1:fix
Open

fix: define error timestamps as ISO datetimes#200
luwqz1 wants to merge 1 commit into
remnawave:devfrom
luwqz1:fix

Conversation

@luwqz1

@luwqz1 luwqz1 commented Aug 5, 2026

Copy link
Copy Markdown

Updates the OpenAPI schemas for RemnawaveNotFoundErrorDto, RemnawaveBadRequestErrorDto and RemnawaveInternalServerErrorDto responses to represent timestamp fields as ISO 8601 datetimes instead of generic strings. This ensures the generated specification includes the correct date-time format.

@snyk-io

snyk-io Bot commented Aug 5, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@what-the-diff

what-the-diff Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

  • Improved Date Handling in Error Classes
    The timestamp field in several error data transfer objects (DTOs) - RemnawaveNotFoundErrorDto, RemnawaveBadRequestErrorDto, and RemnawaveInternalServerErrorDto - has been updated. It is now more robust and accurate because it now uses a specialized format (z.iso.datetime({ local: true, offset: true })) as opposed to a basic string type. This will enhance the quality and reliability of the timestamps in the error reports.

@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the shared error-response DTO schemas so generated OpenAPI documentation identifies timestamps as ISO 8601 date-times.

  • Replaces generic timestamp strings with Zod ISO datetime schemas for 400, 404, and 500 responses.
  • Preserves the existing response fields and error-code enumerations.

Confidence Score: 5/5

The PR appears safe to merge.

The changed DTOs are used for OpenAPI metadata, the selected datetime API is supported by the repository’s Zod version, and actual error timestamps are emitted as compatible UTC ISO 8601 strings.

Important Files Changed

Filename Overview
src/common/utils/startup-app/extra-models.ts Correctly annotates the three documented error timestamps as ISO date-times without changing runtime response handling.

Reviews (1): Last reviewed commit: "fix: define error timestamps as ISO date..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant