fix: update return types of useFragment and useSuspenseFragment to include null - #291
Merged
Merged
Conversation
Member
|
@eMerzh thanks for the contribution :) I’ll release the fix as soon as I can. |
Contributor
Author
|
Ok thanks a lot for your quick 👀 ... |
Member
|
released v10.0.1 https://github.com/relay-tools/relay-hooks/releases/tag/v10.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this bug where a plural fragment was undefined, and the useFragment results as well, but the TS says it can only be an array, so there was no check after that.
i think it looks closer to what react-relay does
@morrys if you can check this out :)
Thanks