Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An Attestation using verificationMethod OTHER currently accepts an empty or whitespace-only verificationMethodDescriptor. The conditional presence rule is satisfied by those values, so a record can pass validation without explaining its method.
Require a non-whitespace character in the shared descriptor slot and add public synthetic negative fixtures for Attestation, RegistryReviewAttestation and RegistryFindingAttestation. This draft is stacked on #90 to let the author incorporate the patch without changing the rest of the schema stack.
Validation: pinned LinkML/runtime 1.11.1 and pySHACL 0.40.1; lint, documentation generation and the authored example suite pass (75 successful assertions plus the existing declared SHACL limitation). Six blank/whitespace probes now fail both validators; six affected-class RDF conversions pass. An independent verifier reproduced the descriptor failures.
A missing OTHER descriptor still fails JSON Schema and passes SHACL because the existing conditional LinkML rule is not emitted by the SHACL generator. This patch does not claim to fix that separate, documented limitation.