Skip to content

Document Snowflake key-pair authentication#6711

Merged
masenf merged 4 commits into
mainfrom
mohamed/eng-9997-snowflake-keypair-docs
Jul 6, 2026
Merged

Document Snowflake key-pair authentication#6711
masenf merged 4 commits into
mainfrom
mohamed/eng-9997-snowflake-keypair-docs

Conversation

@Darksinian

@Darksinian Darksinian commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Darksinian Darksinian requested a review from a team as a code owner July 6, 2026 19:53
@greptile-apps

greptile-apps Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a Key Pair authentication section to the Snowflake integration docs and reorganises the existing OAuth steps under an ## OAuth heading. The new section covers key generation, Snowflake user setup (including the required GRANT ROLE), fingerprint verification with the correct SHA256: prefix note, and env-var configuration.

  • Key-generation commands (openssl genrsa | openssl pkcs8 -topk8) and the public-key derivation step are correct; both unencrypted and passphrase-protected variants are shown.
  • The SQL block correctly includes GRANT ROLE <role> TO USER svc_reflex; and explains that DEFAULT_ROLE alone is insufficient.
  • The fingerprint verification pipeline (openssl rsa -pubin … | openssl dgst -sha256 -binary | openssl enc -base64) matches Snowflake's SHA-256 over DER-encoded SubjectPublicKeyInfo, and the doc properly notes Snowflake prepends SHA256: to the stored value.

Confidence Score: 5/5

Documentation-only change; all shell commands and SQL are technically accurate and safe to merge.

The change is a documentation addition. Every openssl command, the SQL DDL, the fingerprint verification pipeline, and the env-var names are technically correct. The two issues previously identified in review (missing GRANT ROLE and the SHA256: prefix on the fingerprint) are both addressed. No code paths are affected.

No files require special attention.

Important Files Changed

Filename Overview
packages/integrations-docs/src/integrations_docs/docs/snowflake.md Adds a Key Pair authentication section documenting RSA key generation, Snowflake user setup, fingerprint verification, and env-var configuration; restructures the OAuth section under a heading. Previously flagged issues (SHA256 prefix and missing GRANT ROLE) are correctly addressed.

Reviews (4): Last reviewed commit: "Split key generation commands into separ..." | Re-trigger Greptile

Comment thread packages/integrations-docs/src/integrations_docs/docs/snowflake.md Outdated
Comment thread packages/integrations-docs/src/integrations_docs/docs/snowflake.md
@codspeed-hq

codspeed-hq Bot commented Jul 6, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing mohamed/eng-9997-snowflake-keypair-docs (da92bd5) with main (2d446c3)2

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e98c7b4) during the generation of this report, so 2d446c3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25933817b8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/integrations-docs/src/integrations_docs/docs/snowflake.md
@Darksinian Darksinian marked this pull request as draft July 6, 2026 20:27
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Darksinian Darksinian marked this pull request as ready for review July 6, 2026 20:32
@Darksinian Darksinian changed the title ENG-9997: Document Snowflake key-pair authentication Document Snowflake key-pair authentication Jul 6, 2026
@reflex-dev reflex-dev deleted a comment from linear-code Bot Jul 6, 2026
Comment thread packages/integrations-docs/src/integrations_docs/docs/snowflake.md Outdated
Comment thread packages/integrations-docs/src/integrations_docs/docs/snowflake.md
Darksinian and others added 2 commits July 6, 2026 16:17
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@masenf masenf merged commit d54ad96 into main Jul 6, 2026
31 checks passed
@masenf masenf deleted the mohamed/eng-9997-snowflake-keypair-docs branch July 6, 2026 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants