fix(react-sdk): respect initialLoading during initialization#668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ReflagClientProviderusesinitialLoadingfor its first render, but itsstateUpdatedlistener ignores the prop and sets loading totrueas soon as the client emits"initializing".For
ReflagBootstrappedProvider, which defaultsinitialLoadingtofalse, this causes the provider to briefly:loadingComponenttruefromuseIsLoading()This is the adjacent loading-state issue called out as out of scope in #667.
Fix
Track whether the client has completed its first initialization. During the initial
"initializing"lifecycle, continue respectinginitialLoading. Once initialization has completed, preserve the existing behavior where latersetContext()refreshes report loading.This leaves the browser client's lifecycle state and public
stateUpdatedevent sequence unchanged.Test
Add a regression test that holds a bootstrapped client in
"initializing"and verifies that:useIsLoading()remainsfalseAlso keep coverage that subsequent context refreshes still report loading.
Verified with:
yarn workspace @reflag/react-sdk test usage.test.tsx --runyarn oxfmt --check packages/react-sdk/src/index.tsx packages/react-sdk/test/usage.test.tsxyarn oxlint packages/react-sdk/src/index.tsx packages/react-sdk/test/usage.test.tsxyarn exec tsc --project packages/react-sdk/tsconfig.build.json --noEmit