Repository navigation
Hotfix 0.2.2: a QA screenshot reached the v0.2.1 tag - #19
Merged
Merged
Conversation
`.artifacts/` was not ignored, so a git add -A on the 0.2.1 hotfix swept a QA screenshot into the release tag. Removed, and the directory is ignored so the next one cannot follow it. Co-authored-by: Janghoon Lee <savagemanage@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix off
main. Merge with a merge commit, then tagv0.2.2. This branch also carries 0.2.1, so one merge back intodevelopcovers both.What happened
.artifacts/was never ignored, and the screenshot from the 0.2.1 release click-through was sitting in it when I staged that hotfix withgit add -A. A 54 kB PNG went tomainand into thev0.2.1tag, against the rule in CONTRIBUTING that run artifacts do not get committed.The file is removed and the directory is ignored, with the reason stated where the neighbouring rules state theirs: a screenshot taken while checking a change by hand is evidence for a review, reproducible by looking again, and already uploaded where the review can see it.
v0.2.1keeps the file, because a pushed tag is not worth rewriting for 54 kB.mainand every tag after this one are clean.Verification
yarn install --frozen-lockfileresolves on a clean worktree of this branchgit ls-filesreports no tracked files under.artifacts/yarn typecheck,yarn lint,yarn testat 985/985Patch version bumped to
0.2.2across the same five files.