Repository navigation
fix(sdk): declare repository in package.json for npm provenance - #98
Closed
its-janghoon wants to merge 1 commit into
Closed
its-janghoon wants to merge 1 commit into
its-janghoon wants to merge 1 commit into
Conversation
npm rejects a provenance-signed publish (E422) when package.json has no repository.url matching the repository in the sigstore bundle. publish-sdk now authenticates through trusted publishing and signs provenance, so the 0.6.2 run reached that check and failed on the empty field. Declare the repository (with the package directory) so the claim and the bundle agree.
Member
Author
|
Duplicate of #97, which already landed and published @redrob-labs/sdk@0.6.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
publish-sdk(run 38518788158, version 0.6.2) now authenticates via trusted publishing and signs provenance, and npm rejects the upload:What
Adds
repository(git+https://github.com/redrob-labs/redrob-code.git, directorypackages/sdk/js) topackages/sdk/js/package.json.script/publish.tsround-trips the whole object, so the field reaches the published tarball.After merge
Re-dispatch
publish-sdkwithversion=0.6.2,dry_run=false(it checks outdevelop).