Repository navigation
Hold an attachment while redrob acp --attach runs - #93
Merged
Merged
Conversation
With `--attach` the ACP face connected to the shared daemon but never registered in
`/api/clients`, so a Cut, CAD, Browser or Design session kept the daemon counting idle time and it
would have exited mid-session after ten minutes. The CLI now has `Daemon.attach` (the twin of
`attach()` in `@redrob-labs/sdk/daemon`: POST, heartbeat at a third of the TTL, re-attach after a
404 from a restarted daemon, DELETE on detach), and `acp --attach` holds one under the app named by
REDROB_APP (`acp` when unset) until its host closes stdin.
Found during Plan A verification against the 0.6.0 binary: two `acp --attach` processes on one
daemon showed `clients: []`. Checked live after the fix: `clients: [{app: "cut"}]` while the ACP
process runs, empty after stdin closes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--attachthe ACP face connected to the shared daemon but never registered in/api/clients, so a Cut, CAD, Browser or Design session kept the daemon counting idle time and itwould have exited mid-session after ten minutes. The CLI now has
Daemon.attach(the twin ofattach()in@redrob-labs/sdk/daemon: POST, heartbeat at a third of the TTL, re-attach after a404 from a restarted daemon, DELETE on detach), and
acp --attachholds one under the app named byREDROB_APP (
acpwhen unset) until its host closes stdin.Found during Plan A verification against the 0.6.0 binary: two
acp --attachprocesses on onedaemon showed
clients: []. Checked live after the fix:clients: [{app: "cut"}]while the ACPprocess runs, empty after stdin closes.