Repository navigation
Publish the SDK through npm trusted publishing when no token is set - #92
Merged
Merged
Conversation
The 0.6.0 publish failed at "NPM_TOKEN is not set": the token the 0.4.1 publish used is gone, and the package is meant to publish through npm's trusted publishing instead. That needs `id-token: write` on the job and npm >= 11.5.1, which the runner's default Node does not carry; with both, `npm publish` exchanges the GitHub OIDC token for a short-lived credential and attaches provenance on its own. NPM_TOKEN still wins when it is set, so nothing changes for a repository that keeps one. The trust itself lives on npmjs.com (package > Settings > Trusted publisher: redrob-labs/redrob-code, publish-sdk.yml) and is not something this file can grant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.6.0 publish failed at "NPM_TOKEN is not set": the token the 0.4.1 publish used is gone, and the
package is meant to publish through npm's trusted publishing instead. That needs
id-token: writeon the job and npm >= 11.5.1, which the runner's default Node does not carry; with both,
npm publishexchanges the GitHub OIDC token for a short-lived credential and attaches provenance on its own.
NPM_TOKEN still wins when it is set, so nothing changes for a repository that keeps one. The trust
itself lives on npmjs.com (package > Settings > Trusted publisher: redrob-labs/redrob-code,
publish-sdk.yml) and is not something this file can grant.