Repository navigation
Build, sign and tag a release from one commit - #91
Merged
Merged
Conversation
Every job checked out `develop` by name when it started. A merge landing between dispatch and the tag step (#89 landed two minutes after today's release dispatch) meant the binaries were built from one commit and the tag pointed at another. The version job now records the commit it computed from, and the build and publish jobs check out that sha, so a release is one commit from version to tag. The tag push is by explicit ref and works from the detached checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build, sign and tag a release from one commit
Every job checked out
developby name when it started. A merge landing between dispatch andthe tag step (#89 landed two minutes after today's release dispatch) meant the binaries were
built from one commit and the tag pointed at another. The version job now records the commit it
computed from, and the build and publish jobs check out that sha, so a release is one commit from
version to tag. The tag push is by explicit ref and works from the detached checkout.