Repository navigation
Prove the masking switch end to end in the runner test - #86
Merged
Merged
Conversation
Off (the default): the person's text goes out as written. On (regex): the provider sees [EMAIL_1], a placeholder split across two deltas is restored, and the stored reply carries the real value. Privacy.layerWith is the test seam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two runner tests on the real
SessionRunnerLLMharness, so the privacy switch from #84 is checked where it acts rather than only in the pure masker:regex): the provider request carries[EMAIL_1]and not the address; a placeholder the model splits across two deltas ([EMA+IL_1].) is restored; the reply stored in the session carries the real address and no placeholder.Privacy.layerWith(settings)is the test seam (no file write). The session test layer group and replacements are hoisted into two consts so a secondtestEffectcan add one replacement.Tested
bun test test/session-runner.test.ts: 89 pass.tsgo --noEmitclean, prettier clean.