Skip to content

ci: thin PR CI, skip docs/version-only PRs - #142

Merged
its-janghoon merged 1 commit into
developfrom
feat/ci-diet
Oct 20, 2026
Merged

its-janghoon merged 1 commit into
developfrom
feat/ci-diet

Conversation

@its-janghoon

Copy link
Copy Markdown
Member

What's done

PR CI here was already one fast job (checks / repo integrity, ~15 s) plus the seconds-long policy checks; the Chromium build, macOS/Windows packaging and signing are all workflow_dispatch already. This PR trims the rest:

  • checks.yml: removed the push: branches: ["**"] trigger. Every commit was checked twice (push + PR), and merges to develop/main re-ran a check the PR already passed. Added workflow_dispatch for a manual run.
  • checks.yml: a changes step (plain git diff --name-only HEAD^1 HEAD, no new actions) marks docs-only PRs; all other steps skip, and the job still reports success, so the required repo integrity check stays satisfied.
    • Docs = top-level *.md except CHANGELOG.md, docs/**, LICENSE*, .github/*.md.
    • CHANGELOG.md and markdown under sources/, patches/ etc. are NOT docs: check_repo.py reads them.
Before After
PR: checks / repo integrity ~15 s ~15 s (docs-only: ~5 s)
push to any branch: checks ~15 s, every push removed
gitflow, PR policy ~6 s unchanged
Chromium build / sign / publish dispatch only unchanged

What's not done

  • Version-only PRs are NOT skipped: check_repo.py + redrob.py version are exactly the REDROB_VERSION / CHANGELOG / redrob-version.txt agreement gate a release bump needs, and the job is 15 s.
  • release.yml, sign-and-publish.yml, macos.yml, windows.yml, ui-build.yml, agent-extension.yml untouched (ship/publish workflows; a release is in progress).
  • Branch protection and rulesets untouched. Required checks kept: repo integrity, gitflow / branch name follows the convention.

What to review

  • The case patterns in the changes step of .github/workflows/checks.yml.

Intentions

Fewer duplicate runs, no new jobs or third-party actions, required check names unchanged. Do not merge while the release branch is in flight.

- checks.yml: drop the push trigger on every branch (the PR run already covered the commit); add workflow_dispatch.
- checks.yml: a changes step marks docs-only PRs (top-level *.md except CHANGELOG.md, docs/**, LICENSE*, .github/*.md); the remaining steps skip, the required "repo integrity" job still reports success.
- Version bumps still run everything: check_repo is the version/changelog agreement gate.
@its-janghoon
its-janghoon merged commit 2cbb749 into develop Oct 20, 2026
4 checks passed
@its-janghoon
its-janghoon deleted the feat/ci-diet branch October 20, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant