Skip to content

Post 3.8.0 release - #6248

Merged
VaskoAtanasovRedis merged 7 commits into
mainfrom
latest
Jul 21, 2026
Merged

VaskoAtanasovRedis merged 7 commits into
mainfrom
latest

Conversation

@VaskoAtanasovRedis

@VaskoAtanasovRedis VaskoAtanasovRedis commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What

Merge back latest into main

Testing

N/A


Note

Low Risk
Config-only change to feature-flag percentages; no application logic or security paths modified.

Overview
Bumps the remote features config version from 7 to 8 and narrows the whatsNew feature rollout from 100% to 50% (perc: [[0, 100]][[0, 50]]).

Aligns with the post-3.8.0 merge-back: clients that sync features-config.json will pick up the new version and the reduced What's New exposure.

Reviewed by Cursor Bugbot for commit 815499a. Bugbot is set up for automated code reviews on this repo. Configure here.

dantovska and others added 7 commits June 9, 2026 16:10
* feat(RI-7390): promote dev-vectorSet feature flag to vectorSet

Rename the flag end-to-end (backend config, KnownFeatures enum, registry
and strategy registration; frontend enum, slice default, selector and all
consumers; E2E specs). Bump features-config.json to version 3.92. Flag
stays default-off, so E2E specs that exercise Vector Set UI keep their
explicit { vectorSet: true } override.

* feat(RI-7390): enable vectorSet and prodMode for 10% rollout

Flip both flags to flag: true with perc: [[0, 10]] in features-config.json
and bump version to 3.93.
electron-builder 26.15.0 replaced the Go app-builder-bin snap builder with
a pure-TS rewrite (#9829) that ships a broken snap: the launcher references
$SNAP/desktop-init.sh that is never staged, and even past that the bundled
NSS/NSPR libs are unreachable (libnspr4.so: cannot open shared object file)
because SNAP_DESKTOP_RUNTIME / LD_LIBRARY_PATH are not wired up. 26.15.1-.3
all carry the regression.

The snap Wayland fix that motivated moving off 26.0.12 (#9337/#9320) shipped
in 26.2.0 — well before the 26.15.0 rewrite. Pinning to 26.14.0 keeps that
fix (DISABLE_WAYLAND / allowNativeWayland handling) and the proven Go-based
snap builder, which correctly sets SNAP_DESKTOP_RUNTIME and LD_LIBRARY_PATH.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Linux snap failed to launch on modern systems: native modules built on the
ubuntu-24.04 CI runner (glibc 2.39) couldn't load on the core20 base (glibc 2.31)
-> "libm.so.6: version GLIBC_2.38 not found" loading better_sqlite3.node. The old
gnome-3-28-1804 platform also lacked a working GPU driver for current hardware.

Migrate the snap to base core24 via electron-builder's `snapcraft.core24`:
- base core24 -> glibc 2.39, matching the build toolchain (fixes the fatal load)
- GNOME extension (default) -> gnome-46-2404 + mesa-2404/gpu-2404 (modern GPU)
- XDG_SESSION_TYPE=x11 -> forces XWayland, restoring the old allowNativeWayland:false
  behavior (Electron 40 removed ELECTRON_OZONE_PLATFORM_HINT and snapcraft core24
  rejects '=' in an app command, so this env var is the supported mechanism)
- plain browser-support plug -> auto-connects on install (snapd only blocks
  auto-connect for allow-sandbox:true); electron-builder adds --no-sandbox itself
- network / home / password-manager-service plugs preserved

CI: core24 builds via the snapcraft CLI in an LXD container, so the x64 Linux job
installs snapcraft + lxd, grants the LXD socket, and allows iptables FORWARD (the
runner's Docker sets it to DROP, blocking the build container's network). Gated to
runs where the snap target is actually built.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Why 41 and not 42
Electron 42 ships ABI 146. better-sqlite3@12.10.1 fixed the code paths for Electron 42, but the WiseLibs release does not yet publish prebuilt .node assets for ABI 146 — only ABI 145 (Electron 41) and below. Targeting 42 today would silently force every dev install and CI job into a local C++ build (node-gyp), which is exactly what the prebuilt pipeline is here to avoid.

Electron 41 is the highest version with verified prebuilt better-sqlite3 coverage for all our targets (macOS x64/arm64, Linux x64/arm64 glibc + musl, Windows x64). Once WiseLibs publishes the ABI 146 assets, the follow-up to 42 is a one-line bump.
…release-3.8.0-into-latest

# Conflicts:
#	redisinsight/api/config/features-config.json
#	redisinsight/api/src/modules/feature/constants/index.ts
#	redisinsight/ui/src/constants/featureFlags.ts
#	redisinsight/ui/src/pages/browser/components/add-key/constants/key-type-options.ts
#	redisinsight/ui/src/pages/browser/components/filter-key-type/constants.ts
#	redisinsight/ui/src/pages/browser/modules/key-details/components/dynamic-type-details/DynamicTypeDetails.tsx
#	yarn.lock
@VaskoAtanasovRedis
VaskoAtanasovRedis requested a review from a team as a code owner July 21, 2026 07:54
@VaskoAtanasovRedis
VaskoAtanasovRedis merged commit 18c3fde into main Jul 21, 2026
87 of 88 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 93.14% 16522/17738
🟡 Branches 75.35% 5284/7013
🟢 Functions 87.47% 2534/2897
🟢 Lines 93% 15800/16989

Test suite run success

3694 tests passing in 322 suites.

Report generated by 🧪jest coverage report action from 815499a

@github-actions

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.29% 27850/33438
🟡 Branches 69.33% 11913/17184
🟡 Functions 78.24% 7403/9462
🟢 Lines 83.74% 27113/32379

Test suite run success

7829 tests passing in 865 suites.

Report generated by 🧪jest coverage report action from 815499a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants