[dx] warn about deprecated beforeTraverse() method once FileNode is ready#7768
Merged
Conversation
TomasVotruba
force-pushed
the
tv-warn-about-before-traverse
branch
from
0cd995e to
08735ab
Compare
TomasVotruba
force-pushed
the
tv-warn-about-before-traverse
branch
from
8bd045f to
aec723a
Compare
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Rector::beforeTraverse()is now marked as soft@final, but not everyone uses PHPStan to check their custom rules and has this check enabled.This is a simple feedback on Rector's run to prepare about depreaction of this method in safe way everyone notices. That way we prevent WTF when this method will actually become
finaland removed in the future.Related PR #7728