Skip to content

Alternative second ad placement for revshare partners#696

Open
davidfischer wants to merge 2 commits into
mainfrom
davidfischer/logo-large-second-placement
Open

Alternative second ad placement for revshare partners#696
davidfischer wants to merge 2 commits into
mainfrom
davidfischer/logo-large-second-placement

Conversation

@davidfischer
Copy link
Copy Markdown
Contributor

Adds a second possible ad placement for revenue share partners only. Still only a single placement will be selected, but this change offers a second possible placement in the footer with a larger placement. The server will decide which placement to choose based on inventory.

Branched from #695

This adds a second possible ad placement for revenue share partners.
Still only a single placement will be selected, but this change offers a
second possible placement in the footer with a larger placement.
@davidfischer davidfischer requested review from a team and humitos as code owners May 1, 2026 23:52
@davidfischer davidfischer requested a review from agjohnson May 1, 2026 23:52
@ericholscher ericholscher self-requested a review May 20, 2026 16:15
Base automatically changed from davidfischer/logo-large-ad-placement to main May 21, 2026 04:00
@github-project-automation github-project-automation Bot moved this to Planned in 📍Roadmap May 21, 2026
Copy link
Copy Markdown
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks simple enough. Needs the merge from the prior change in the other PR.

We should also ensure the projects know this is coming before we ship it.

@davidfischer
Copy link
Copy Markdown
Contributor Author

We should also ensure the projects know this is coming before we ship it.

I spoke with the pallets team directly. The other main revshare partner is Celery.

@ericholscher
Copy link
Copy Markdown
Member

ericholscher commented May 22, 2026

Should we follow up w/ Celery on the payout email thread perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Planned

Development

Successfully merging this pull request may close these issues.

2 participants